MinkExtension icon indicating copy to clipboard operation
MinkExtension copied to clipboard

A suggestion

Open jorgealonso78 opened this issue 9 years ago • 5 comments

/** * @Given I am on :urlPath * @When I go to :urlPath * @Given I am on home page * @When I go to home page */ public function visit($urlPath="/") { $this->visitPath($urlPath); }

jorgealonso78 avatar Nov 11 '16 19:11 jorgealonso78

This better to be sent as a Pull Request right away.

aik099 avatar Nov 11 '16 19:11 aik099

Okay but I don't have time right now for clone the repo, create a branch,make the change and create the pull request. If the suggestion is take maybe someone else can do it (a more active contributor)

jorgealonso78 avatar Nov 11 '16 20:11 jorgealonso78

You can just edit on GitHub. How ever I didn't like that, because this steps already implemented in my Context, so after update I'll need to fix this.

spolischook avatar Nov 11 '16 20:11 spolischook

Aren't there any steps already that call visit or visitPath?

aik099 avatar Nov 11 '16 20:11 aik099

thk @spolischook I di not know that I can do the change over the GitHub I did my suggests changes in https://github.com/Behat/MinkExtension/pull/260

jorgealonso78 avatar Nov 11 '16 20:11 jorgealonso78