MinkExtension icon indicating copy to clipboard operation
MinkExtension copied to clipboard

Add response header outcomes

Open erikwebb opened this issue 11 years ago • 8 comments

Depends on https://github.com/Behat/Mink/pull/623

erikwebb avatar Nov 30 '14 03:11 erikwebb

This Mink PR has been replaced with https://github.com/minkphp/Mink/pull/636

stof avatar Jan 23 '15 01:01 stof

Are you sure? The https://github.com/minkphp/Mink/pull/636 is adding methods to WebAssert class in Mink that are then used by this PR to add new methods to MinkContext.

aik099 avatar Jan 23 '15 08:01 aik099

There is a typo in my previous comment. It should have been The Mink PR, not This Mink PR

stof avatar Jan 23 '15 08:01 stof

Maybe you should just close the PR is we're no longer plan to continue work on it?

aik099 avatar Jan 23 '15 09:01 aik099

Well, this PR is not obsolete. It exposes the new assertions to the Behat land

stof avatar Jan 23 '15 09:01 stof

Then your comment should say this to be 100% clear:

The Mink's PR mentioned in task description was replaced by minkphp/Mink#636.

aik099 avatar Jan 23 '15 09:01 aik099

The Mink PR has been merged. the feature is now in Mink 1.7.x-dev. I will wait a bit with this PR to avoid forcing to use a dev version of Mink in the extension.

stof avatar Feb 04 '15 17:02 stof

@stof Anything I can do to help this land?

danielbachhuber avatar Oct 31 '16 21:10 danielbachhuber