Gherkin
Gherkin copied to clipboard
Improve loaders load() handling
-
load()is now guarded by a call tosupports()(throwing aLogicExceptionwhen that returnsfalse) - improves narrowing the real type of
mixed $resourcewith the use of generics
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.25%. Comparing base (
b4870b1) to head (dc84da0). Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #372 +/- ##
============================================
+ Coverage 96.23% 96.25% +0.01%
- Complexity 654 656 +2
============================================
Files 43 44 +1
Lines 1940 1949 +9
============================================
+ Hits 1867 1876 +9
Misses 73 73
| Flag | Coverage Δ | |
|---|---|---|
| php8.1 | 96.25% <100.00%> (+0.01%) |
:arrow_up: |
| php8.1--with=symfony/yaml:^5.4 | 96.25% <100.00%> (+0.01%) |
:arrow_up: |
| php8.1--with=symfony/yaml:^6.4 | 96.25% <100.00%> (+0.01%) |
:arrow_up: |
| php8.2 | 96.25% <100.00%> (+0.01%) |
:arrow_up: |
| php8.3 | 96.25% <100.00%> (+0.01%) |
:arrow_up: |
| php8.4 | 96.25% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@stof could you or @carlos-granados review & approve this and #373 please? 🙏
@stof @carlos-granados would one of you have a chance to take a look at this please?