RawTherapee icon indicating copy to clipboard operation
RawTherapee copied to clipboard

Document Inspect

Open Beep6581 opened this issue 3 years ago • 7 comments

I can't find documentation of the "Inspect" tab anywhere, nor keyboard shortcuts.

Beep6581 avatar Feb 15 '21 13:02 Beep6581

Very much agreed. It is very scattered and incomplete after the modifications by @rfranke

You can find some tiny mention if you Ctrl+F for 'inspect' on these RawPedia pages: http://rawpedia.rawtherapee.com/Getting_Started and http://rawpedia.rawtherapee.com/File_Browser

Thanatomanic avatar Feb 15 '21 13:02 Thanatomanic

Indeed.

But as I think has been mentioned elsewhere, its behavior is more or less random, as in:

  • it's not clear if pressing F will open the inspect window and leave it open, or you have to keep pressing F to keep viewing the image
  • do you have to press Esc or F again, if the window keeps opened when you release F?
  • does the inspect window have a title bar and close button, or is it a frameless window?
  • may I zoom in or not?
  • may I view the next/previous image without leaving the inspect window or not?

I say this because I have experienced most of those different behaviors in a single RT session (no experience in the next/previous image, though).

From a documentation point of view, I think it's better those points get clarified before writing anything.

TechXavAL avatar Feb 15 '21 18:02 TechXavAL

Probably we should discuss first how we really want to interact with "inspect". I think it would be enough to simply launch a maximized inspector window - with a title bar, not fullscreen. It stays open until you press ESC or close it with the icon. It makes the interaction and the code unnecessarily complicated when you have to manipulate the current window state and persistence with shortcuts. Also I just had an idea: Why not make it possible to generally inspect by pressing "f" (or whatever shortcut) and the option in the settings controls whether a new window pops up or you switch to the "inspect" tab? With the tab you have to move your mouse out of the file browser to select the tab, then move back to the image you want to inspect, hovering all the icons in between which introduces quite a big freeze as the intermediate images get loaded, too. Hovering an image and just pressing "f" to open the "inspect" tab would fix this.

ff2000 avatar Feb 21 '21 07:02 ff2000

There has been some discussion in https://github.com/Beep6581/RawTherapee/issues/5867 and the development took place here https://github.com/Beep6581/RawTherapee/pull/5593. In hindsight, I think this functionality should have had more discussion and testing before merge.

Thanatomanic avatar Feb 23 '21 17:02 Thanatomanic

In hindsight, I think this functionality should have had more discussion and testing before merge.

I agree. My fault :(

heckflosse avatar Feb 23 '21 18:02 heckflosse

From #5593 and #5872:

Two settings in preferences

  • Zoom images by scrolling
  • Open inspector in own window or full-screen (restart required)

Keyboard and mouse (separate window/full-screen)

  • hold f to view full image in full-screen inspector
  • hold shift+f to view image at 1:1 in full-screen inspector
  • click inspector to pin the inspector (does not close when you release f)
    • Esc to close
    • z or shift+f for 1:1
    • f for full image
    • scroll to pan image (zooms if "Zoom images by scrolling" is checked)
    • hold Alt and scroll to zoom (pans if "Zoom images by scrolling" is unchecked)
    • click+drag to pan image
    • F11 to toggle between full-screen/window
    • hover over thumbnail to change image, view part of the image under the cursor
  • Right-click thumbnail -> Inspect to view image at 1:1 in inspector window

Inspector tab behavior is unchanged.

Lawrence37 avatar Feb 27 '21 20:02 Lawrence37

Some minor behavior changes in #6222:

  • Window is initially full-screen. You can resize the window and your window manager will remember the size until you close RT.
  • Right-click thumbnail -> Inspect shows full image instead of a 1:1 view.

Lawrence37 avatar May 16 '21 18:05 Lawrence37