BeeStation
[TM Probably] Sabre insanity, also known as one proc adjustment that might possibly fix stuff
About The Pull Request
There is some bug going on with miner sabres sometimes getting nullspaced and I spent hours without finding out why. The one part of the entire proc chain that is basically always questionable is the weird ships[] list so I passed some better values for now and we'll see if that fixes it. TM this please. We'll see if someone gets nullspaced with this and if someone does I go back to the mines.
Why It's Good For The Game
Fix man good.
Changelog
:cl: fix: Possibly fixes some weird Sabre behavior. fix: Also makes one single gun check of the plasma caster slightly safer. /:cl:
do you want to keep this testmerged until we find the issue? Otherwise I'd like for you to move your comments to a new issue instead so someone else can potentially look at it instead.
Essentially, this might resolve it or it might not. It's the only place I found that looked potentially volatile, and I wasn't able to reproduce how to trigger the issue in the first place, despite someone managing to trigger it in the first system without having jumped. It also didn't cause a runtime during the time I helped someone out on the server.
If it doesn't happen again, this was probably it, if it does, I'll have to check vars again and question them aswell so I can have some different occurances to compare.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Found another issue, did a bit of rewriting things that might resolve even more or might brick some edge case if I forgot something. (Appears to work properly in testing but you know how it is)
I think this has been working? Not heard of any miners getting sent to nullspace or things going wrong that would be caused by this. Probably good to merge.