NSV13 icon indicating copy to clipboard operation
NSV13 copied to clipboard

[PORT] Flavor Texts/Flavour Text

Open Bobbanz1 opened this issue 2 years ago • 3 comments

About The Pull Request

Ports the following PRs from various sources: Beestation: 2472 Whitesands: 491

Why It's Good For The Game

Flavor Text is good for roleplaying as it shows character appearances and minor roleplay quirks!

Changelog

:cl: add: Flavortext can now be set to be shown to anyone who examines you. fix: Clicking the "cancel" button will no longer reset your flavor text to nothing. /:cl:

Bobbanz1 avatar Oct 07 '22 19:10 Bobbanz1

To answer the questions some might have about this feature.

  1. Is it mandatory to fill in the flavor text?

No it’s not mandatory (required) to fill in the flavor text in order to be allowed to join the round. It’s purely optional.

  1. Can you port this to Beestation?

As I’d like to point out, they tried to port it once and then the OP (Original Poster) closed the PR, I’d also like to point out that theirs wouldn’t have been saved to the player’s save file as they had forgotten to give the code the ability to read the save file and import the saved flavor text.

  1. Can you change the text mid-round?

No, I don’t know what magic I’d have to pull off in order to make the code capable of doing that.

Bobbanz1 avatar Oct 08 '22 11:10 Bobbanz1

I can't wait to have to refactor this to work with the upcoming preferences update! (If you can update it to work on the latest Beestation version that would be greatly appreciated)

Bokkiewokkie avatar Oct 14 '22 18:10 Bokkiewokkie

I can't wait to have to refactor this to work with the upcoming preferences update! (If you can update it to work on the latest Beestation version that would be greatly appreciated)

@Bokkiewokkie I'll have to figure out how their new preference system works before I can give a definitive answer, but probably yes.

Bobbanz1 avatar Oct 15 '22 10:10 Bobbanz1

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 01 '22 22:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 11 '22 22:11 github-actions[bot]

Note: will need to update the database schema accordingly

Bokkiewokkie avatar Nov 18 '22 19:11 Bokkiewokkie

Note: will need to update the database schema accordingly

Could you explain?

Bobbanz1 avatar Nov 22 '22 07:11 Bobbanz1

Note: will need to update the database schema accordingly

Could you explain?

I was under the impression flavor text was a seperate character variable, though after looking at it I realized it isn't. I think it's best if we do make it one.

Bokkiewokkie avatar Nov 25 '22 19:11 Bokkiewokkie