NSV13 icon indicating copy to clipboard operation
NSV13 copied to clipboard

Allows subjects of the dominion to speak to eachother

Open Pontenerd opened this issue 3 years ago • 15 comments

About The Pull Request

Makes etherials able to speak and understand moffic, and moths can understand voltaic

Why It's Good For The Game

Both races are part of the dominion of light, they should be able to understand one another

Changelog

:cl: tweak: changes the languages moths and etherials can understand

/:cl:

Pontenerd avatar Sep 08 '22 18:09 Pontenerd

No.

Karmic-Skink avatar Sep 08 '22 23:09 Karmic-Skink

No.

Can you elaborate on this further? I've already gotten approval from the lore lead about this

Pontenerd avatar Sep 08 '22 23:09 Pontenerd

No.

This was made on my request, beginning to implement features based on the written lore that's sat for too long without any attention or code implementations.

BetaCentari avatar Sep 08 '22 23:09 BetaCentari

No.

This was made on my request, beginning to implement features based on the written lore that's sat for too long without any attention or code implementations.

Non-canon "lore" will not be integrated into code. Use common.

Karmic-Skink avatar Sep 09 '22 00:09 Karmic-Skink

No.

This was made on my request, beginning to implement features based on the written lore that's sat for too long without any attention or code implementations.

Non-canon "lore" will not be integrated into code. Use common.

I am the lore coordinator now and I have decided that this along with much of the written lore on the Dominion of Light is in fact canon. If you disagree then we can discuss this elsewhere.

BetaCentari avatar Sep 09 '22 00:09 BetaCentari

The concepts of "Dominion of Light", "Draconic Empire" and "Federation" were rejected shortly after they were proposed due to misaligning with the design goals and intentions of NSV13.

This discussion was had over a year ago. If that hasn't been properly communicated, I suggest you take it up with the former lore coordinator who appears to have failed to communicate that fact.

Karmic-Skink avatar Sep 09 '22 00:09 Karmic-Skink

Significant lore plot holes aside, this is effectively both a nerf secrecy and a buff scrutiny for the respective species. Messing with languages, particularly as we already have IPCs with AI level language abilities, is ill advised.

Karmic-Skink avatar Sep 09 '22 11:09 Karmic-Skink

Significant lore plot holes aside, this is effectively both a nerf secrecy and a buff scrutiny for the respective species. Messing with languages, particularly as we already have IPCs with AI level language abilities, is ill advised.

I've only just begun my work as loor coordinator and I'm actively mending those plot holes. I understand the prospects of scrutiny and secrecy though I have been asked to nerf IPC language abilities, a PR will be through shortly. 😄

BetaCentari avatar Sep 09 '22 12:09 BetaCentari

Per our discussions the moth-ethereal connection is supported by lore which has been made canon, so this is fine. We still won't be making the extra factions into influential entities in gameplay but flavor things like this are alright, and it's only one species pair.

covertcorvid avatar Sep 09 '22 16:09 covertcorvid

Significant lore plot holes aside, this is effectively both a nerf secrecy and a buff scrutiny for the respective species. Messing with languages, particularly as we already have IPCs with AI level language abilities, is ill advised.

I've only just begun my work as loor coordinator and I'm actively mending those plot holes. I understand the prospects of scrutiny and secrecy though I have been asked to nerf IPC language abilities, a PR will be through shortly. 😄

Personally, I still think an organic being able to read electricity without physical enhancement is dumb.

But yeah, your predecessor basically ignored 99% of non-lore team feedback.

Karmic-Skink avatar Sep 09 '22 22:09 Karmic-Skink

Significant lore plot holes aside, this is effectively both a nerf secrecy and a buff scrutiny for the respective species. Messing with languages, particularly as we already have IPCs with AI level language abilities, is ill advised.

I've only just begun my work as loor coordinator and I'm actively mending those plot holes. I understand the prospects of scrutiny and secrecy though I have been asked to nerf IPC language abilities, a PR will be through shortly. 😄

I've sent Bokkie a series of DMs about how we can potentially implement this (and other stuff) better. Standby for jankcode.

Karmic-Skink avatar Sep 10 '22 09:09 Karmic-Skink

Significant lore plot holes aside, this is effectively both a nerf secrecy and a buff scrutiny for the respective species. Messing with languages, particularly as we already have IPCs with AI level language abilities, is ill advised.

I've only just begun my work as loor coordinator and I'm actively mending those plot holes. I understand the prospects of scrutiny and secrecy though I have been asked to nerf IPC language abilities, a PR will be through shortly. 😄

I've sent Bokkie a series of DMs about how we can potentially implement this (and other stuff) better. Standby for jankcode.

Originally I wanted to create a separate language though this was recommended instead. Do you think that adding another language for moths and ethereals to have would be a good way to implement this feature? (Along with taking away IPC language rights)

BetaCentari avatar Sep 10 '22 12:09 BetaCentari

Significant lore plot holes aside, this is effectively both a nerf secrecy and a buff scrutiny for the respective species. Messing with languages, particularly as we already have IPCs with AI level language abilities, is ill advised.

I've only just begun my work as loor coordinator and I'm actively mending those plot holes. I understand the prospects of scrutiny and secrecy though I have been asked to nerf IPC language abilities, a PR will be through shortly. 😄

I've sent Bokkie a series of DMs about how we can potentially implement this (and other stuff) better. Standby for jankcode.

Originally I wanted to create a separate language though this was recommended instead. Do you think that adding another language for moths and ethereals to have would be a good way to implement this feature? (Along with taking away IPC language rights)

DISREGARD, I've been informed of your idea, Skink and I'm so on board for it! Great idea.

BetaCentari avatar Sep 10 '22 12:09 BetaCentari

DISREGARD, I've been informed of your idea, Skink and I'm so on board for it! Great idea.

Yeah, I hope it works. Should be a good way of inserting that sort of stuff in optionally to give people a bit more of a background choice.

Karmic-Skink avatar Sep 11 '22 09:09 Karmic-Skink

We'll be keeping this as a test merge until we get the other system up and running, and retiring this if it proves to work, otherwise we can just do this unideal solution.

Edit: Also please update the PR CL and comments to reflect the IPC changes.

Karmic-Skink avatar Sep 21 '22 13:09 Karmic-Skink