NSV13 icon indicating copy to clipboard operation
NSV13 copied to clipboard

cargo suply manifests do not always have the correct ship name in the destination section

Open John-Gregson opened this issue 2 years ago • 1 comments

Round ID: 4658

Testmerges: unsure

Reproduction: ordered 6 crates on the atlas (2 pdc ammo crates 2 nac shell crates and 2 gunpowder crates) when stamping the supply manifests i realised that 2 of the manifests had different names to the others. the ships name at the time was "NSV Weed Smoker" and 4 of the manifests had the correct name of "NSV Weed Smoker" while the 2 others had the names "NSV Thor" and "NSV Corvus". for reproduction I suppose order 6 crates on the atlas and check what it says under destination

screenshots below

Screenshot (1896) Screenshot (1898)

John-Gregson avatar Jul 24 '22 18:07 John-Gregson

Yep, the game calls the proc to create a new station name, instead of actually looking for the actual name. https://github.com/BeeStation/NSV13/blob/da9faec150a40dda84b22eddee9bb563f31d0c02/code/modules/cargo/order.dm#L46

Bokkiewokkie avatar Aug 05 '22 23:08 Bokkiewokkie

Issue has been fixed as of the Beebase @Bokkiewokkie

Bobbanz1 avatar May 02 '23 08:05 Bobbanz1