NSV13 icon indicating copy to clipboard operation
NSV13 copied to clipboard

make gauss guns require no power

Open Kenionatus opened this issue 2 years ago • 7 comments

About The Pull Request

Gauss guns currently require power in the turret's room to operate. Prebuilt turrets seem to be powered by default but rebuilt turrets are usually unpowered because they're in an area without APC. Making them require no power is an easier fix than making new powered areas in space for each gauss battery.

Why It's Good For The Game

bugfix without much side effects (Fixes #1855)

Changelog

:cl: fix: rebuilt gauss guns should now always be usable /:cl:

Kenionatus avatar Jun 14 '22 18:06 Kenionatus

Making them require no power is an easier fix than making new powered areas in space for each gauss battery.

Fix it properly. -1

Karmic-Skink avatar Jun 14 '22 21:06 Karmic-Skink

@Karmic-Skink

Fix it properly. -1

I'm not much of a mapper. If you go through all of the maps and add APC powered areas, I'll see if I can change mapper placed Gauss Guns to no have power by default so unpowered ones get caught early.

Addendum: NAC turrets were previously changed to not require power, so this PR would bring them in line with each other.

Kenionatus avatar Jun 15 '22 08:06 Kenionatus

@Karmic-Skink

Fix it properly. -1

I'm not much of a mapper. If you go through all of the maps and add APC powered areas, I'll see if I can change mapper placed Gauss Guns to no have power by default so unpowered ones get caught early.

Addendum: NAC turrets were previously changed to not require power, so this PR would bring them in line with each other.

NACs are chemically propelled.

Draw power from the chair location.

Karmic-Skink avatar Jun 15 '22 21:06 Karmic-Skink

Changing the maps to have the gauss bay areas cover the turrets on the other deck would be a better solution.

That sounds like a dodgy work around.

Karmic-Skink avatar Jun 18 '22 11:06 Karmic-Skink

I think the best solution would be to wire a cable to every gauss gun and make them draw a significant (but not too large not not majorly mess up energy balancing) amount from it. I just don't really feel like mapping.

Taking power from below would be quite the overhaul, since the "actual" gauss gun is the turret, which is classified as a machine. Loading rack is an optional part automatically created below if possible and gunner chair needs to be constructed manually and is also optional.

Kenionatus avatar Jun 20 '22 20:06 Kenionatus

I think the best solution would be to wire a cable to every gauss gun and make them draw a significant (but not too large not not majorly mess up energy balancing) amount from it. I just don't really feel like mapping.

Taking power from below would be quite the overhaul, since the "actual" gauss gun is the turret, which is classified as a machine. Loading rack is an optional part automatically created below if possible and gunner chair needs to be constructed manually and is also optional.

Can you please (at least just by coding, the mapping can be done by someone else if you really don't want to) add that instead then? We're not gonna merge this PR in its current state

Bokkiewokkie avatar Jul 29 '22 19:07 Bokkiewokkie

Ok. Put this on the top of my mental NSV todo list.

Kenionatus avatar Jul 29 '22 23:07 Kenionatus