NSV13 icon indicating copy to clipboard operation
NSV13 copied to clipboard

Ship exploding toggles OOC

Open Bokkiewokkie opened this issue 5 years ago • 4 comments

Round ID:1610

Description

When the ship explodes it ends the round and toggles the OOC chat, however if the round has already ended it just toggles OOC chat back off. In this picture the round already ended because the shuttle docked at CC, but the ship exploding then promtply disabled OOC again. This might also ~~not~~ work the other way around but I'm not sure about that. image

Bokkiewokkie avatar Dec 03 '20 12:12 Bokkiewokkie

This issue has been inactive for long enough to be automatically marked as stale. If this was a bug report and hasn't been addressed yet, and is still a probelm, please don't hesitate to notify a maintainer.

github-actions[bot] avatar Jan 03 '21 00:01 github-actions[bot]

can confirm, still occurs image round was ended by end round verb, then ship was deleted from viewscreen.

AU518987077 avatar Feb 16 '21 01:02 AU518987077

toggle_ooc verb doesn't seem to be functioning properly. it's called in SSticker.mode.check_finished but instead fully toggles OOC instead of setting it to true. simplifying the code to GLOB.ooc_allowed = toggle in ooc.dm doesn't help either. TRUE/FALSE aren't being parsed correctly, it seems

Corsaka avatar Mar 06 '21 13:03 Corsaka

Reproduced on current master

IndusRobot avatar Jul 05 '21 00:07 IndusRobot

Solved by beebase. Commit da5212fd484273293524c7800bfaae11a59f6764 / Bee PR #7664

Kenionatus avatar Dec 14 '22 09:12 Kenionatus

@covertcorvid Can be closed according to my testing.

Kenionatus avatar Dec 14 '22 09:12 Kenionatus