BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

Vending QOL

Open Tsar-Salat opened this issue 1 year ago • 12 comments

Ports:

  • https://github.com/tgstation/tgstation/pull/68111

About The Pull Request

This adds categories to Vendors.

This is a copy of #8280, except I 86'd basically all the stuff that makes it sit for months.

Why It's Good For The Game

no longer a 500 item goddamn list in vendors like the ClothesMate. Introduces Categorizing vendors for ease of access.

Testing Photographs and Procedure

Screenshots&Videos

https://github.com/BeeStation/BeeStation-Hornet/assets/62388554/9c68989d-69b8-4234-af0a-2cd6dad1ab46

Changelog

:cl: RKz, Twaticus, GoldenAlpharex add: Categorized Vendors, it should be a lot less tedious to look for items in them now balance: you can no longer use departmental cards to buy through vendors code: updated awesome font code: cleaned up flag.dm /:cl:

Tsar-Salat avatar Aug 18 '23 06:08 Tsar-Salat

i hate javascript i hate javascript i hate javascript i hate javascript i hate javascript i hate javascript i hate javascript i hate javascript i hate javascript i hate javascript i hate javascript i hate javascript

Tsar-Salat avatar Nov 22 '23 20:11 Tsar-Salat

Fine. Screw you then typescript

Tsar-Salat avatar Dec 11 '23 11:12 Tsar-Salat

GAGS?

gags 🤮

itsmeow avatar Dec 19 '23 11:12 itsmeow

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 24 '23 12:12 github-actions[bot]

GAGS?

gags 🤮

Im makin it cool (Being recolorable might make GAGS like, actually worth our time.)

😎

Tsar-Salat avatar Dec 28 '23 03:12 Tsar-Salat

Nobody seems to know exactly how dynamic resources work, but depending on how that functions, allowing users to colour GAGs items with any colour they want could be an absolutely horrible idea; but I will assume that byond has a decent dynamic resources implementation for now and say that it should be fine. It's still worse than overlays though, and that colouring menu seems more like a dev menu than one to show to the players. image

  1. It is weirdly tall for no apparent reason
  2. What does Design Type mean and why is that a text input?
  3. The player shouldn't have to see the full colour string used by the backend of GAGs when picking colours for their shoes.
  4. Is the icon state panel necessary?

PowerfulBacon avatar Jan 11 '24 22:01 PowerfulBacon

  1. It is weirdly tall for no apparent reason

Our styling is broken for some reason. I asked in Discord a while back, but I didnt really get a response on how to fix the undefined alignment

image

2. What does Design Type mean and why is that a text input?

At class atm, will get back to you

3. The player shouldn't have to see the full colour string used by the backend of GAGs when picking colours for their shoes.

The colorpicker used in the preference menu uses the same thing though?

Personally, I think it allows for finer control if one wants to copy the same hex across multiple rounds, instead of taking a picture and repeating the saturation, color & other values.

Tsar-Salat avatar Jan 22 '24 16:01 Tsar-Salat

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 23 '24 20:01 github-actions[bot]

This has sat for 3-2 months, in that time Ive lost my interest.

I can tell when active avoiding is happening, so Ill just strip the GAGS shit out.

Tsar-Salat avatar Jan 26 '24 07:01 Tsar-Salat

The GAGS is fine, I just want rustg gags in first. Things are slow right now.

itsmeow avatar Jan 26 '24 09:01 itsmeow

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 13 '24 03:02 github-actions[bot]

Leaving this one for Kat to review.

Rukofamicom avatar Mar 03 '24 15:03 Rukofamicom

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 02 '24 17:04 github-actions[bot]