BeeStation-Hornet
BeeStation-Hornet copied to clipboard
BeeStation
Ports Reagent lookup
Ports:
- https://github.com/tgstation/tgstation/pull/56868
- https://github.com/tgstation/tgstation/pull/57156
- https://github.com/tgstation/tgstation/pull/72358
Ports from Monke:
- https://github.com/Monkestation/MonkeStation/pull/402
About The Pull Request
This adds the reagent lookup UI from /tg/. It lets you look at in game reagent recipes, components, and lets you sort the list by tags. Tags are applied to both reagents made in Chemistry, as well as bar drinks.
closes #10774
Why It's Good For The Game
I have gotten the impression from our Headcoder and maintainers that moving away from wiki-based knowledge and into ingame info is a current goal of ours.
Testing Photographs and Procedure
Screenshots&Videos
- Reaction Search
- Sort by tags
- Reagent Lookup
Changelog
:cl: RKz, dwasint, Thalpy, gorock, mothblocks add: Adds reagent lookup to chemistry to decrease reliance on wiki add: most chem recipes now have tags assigned to them. This includes drugs, plant reagents, and bar drinks code: improved code related to reagent lists and chem ids code: reagent tags should be enforced on all future reagent recipes added /:cl:
This is fantastic, thank you for porting this.
I have gotten the impression from our Headcoder and maintainers that moving away from wiki-based knowledge and into ingame info is a current goal of ours.
This should be a general push across the board. I'd like to see about changing out our guide "books" that actually just open up a specific wiki article. Give every department a small stack of books that actually explain how to do the job in-game.
I would like to ask if it's possible to segregate the bartender recipes from the chemistry recipes? I'm not sure what machine a bartender would use to look up their recipes, but I feel like it would be a good additional step.
possible to segregate the bartender recipes from the chemistry recipes?
Most reagents are sorted by category, primarily. Drinks are sorted by REACTION_TAG_DRINK.
In my image above, I searched for DRINKS that are EASY to make, and effect BRUTE and BURN damage.
I'm not sure what machine a bartender would use to look up their recipes
So far, no such machine is available to a bartender. That is a for a future project, though.
That is a for a future project, though.
I'd suggest removing the option to search for drinks, food and slime from the chemistry station entirely.
Credit the original authors, please.
Done.
I'd suggest removing the option to search for drinks
What is your reasoning?
Immersion.
It doesn't make sense for a chemistry station to report how to make drinks and food, or have the details on every xenobio slime reaction.
I do think they should be enabled for the relevant departments, but not as part of the chem dispenser.
It doesn't make sense for a chemistry station to report how to make drinks and food, or have the details on every xenobio slime reaction.
It was not my intention for this system to be Chemisty-centric.
I would like to expand the reagent recipe lookup system as a whole to replace the use of the wiki ingame for recipes entirely.
If I found out a good way to incorporate this for Bartending as well, I would have incorporated it here.
I would like the same system to be shared across multiple of the devices in the future, so I would prefer not removing the tags from the recipes.
Again, this PR exists only to get our foot into the door. I have plans for further accessibility for new players later on
If I found out a good way to incorporate this for Bartending as well, I would have incorporated it here
Add the interface buttons for it to the drink dispensers, but only for drinks.
As for xenobio and chef, Give them a console with the sole purpose of looking up slime/cooking recipes.
Again, this PR exists only to get our foot into the door. I have plans for further accessibility for new players later on
And again, I applaud you for this, it's fantastic. I'm not asking you to neuter it in any way - I'm just asking you to remove the buttons not relevant to chemistry from the chemistry machine.
If you're not willing to move those buttons to appropriate machines in appropriate locations within this PR, that's fine - like you said they can be added later. I just don't think they should be added in an incorrect location just for the sake of having it on a machine right now.
Again, this PR exists only to get our foot into the door. I have plans for further accessibility for new players later on
And again, I applaud you for this, it's fantastic. I'm not asking you to neuter it in any way - I'm just asking you to remove the buttons not relevant to chemistry from the chemistry machine.
If you're not willing to move those buttons to appropriate machines in appropriate locations within this PR, that's fine - like you said they can be added later. I just don't think they should be added in an incorrect location just for the sake of having it on a machine right now.
I think Ruko makes a fair point. Now what you could do is move the ability to look up drinks to the booze and drink dispensers in the Bar. That'd be a good compromise I think. Oh guh Ruko already suggested that, I'm blind.
I would rather leave as-is.
Now what you could do is move the ability to look up drinks to the booze and drink dispensers in the Bar
I want to test the feature overall first.
I would rather just get this merged at its simplest iteration. I have already had this up for over a month, so I'd rather not expand it beyond its current file count(which would delay its review) as I need it to fit well with my addiction pr.
I agree that it should probably just display the chemicals that can be made with something that can be produced from the machine, although that sounds difficult since the reagents can change dynamically and you have to account for chains (products of products.)
At the very least drink dispensors shouldn't show standard chem recipes imo
Could also potentially do it minecraft style and have it so recipes only show if you have made one of their inputs (Anything that can be made with base reagents shows, then more unlocks as you create those (Although it might get complicated to find specific things with the sheer number of pointless reactions we have))
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
although that sounds difficult since the reagents can change dynamically and you have to account for chains (products of products.)
It is. I would rather just help people who use chemistry now. (and I dont really know how to separate chem and drink lists)
At the very least drink dispensors shouldn't show standard chem recipes imo
I dont really understand what you mean. Something like 7b8abdd ?
I'm, for the time being, considering this as closing #10774.
It likely doesn't fulfill what bacon was envisioning exactly, but it fulfills the criteria of displaying the exact heat and recipe requirements to make a reagent, as well as a sorting system to look up certain reagents.
Is this ready for review right now?
Haven't read through all the comments, just asking because at a quick glance/skim it doesn't appear to be, but it isn't drafted.
Is this ready for review right now?
Haven't read through all the comments, just asking because at a quick glance/skim it doesn't appear to be, but it isn't drafted.
Yes. I believe I addressed all the major blocking points including the drinks dispensers, and the UI resetting for multiple clients.
It is good to go. Nearly every tg-adjacent server has this lookup. I think with the lookup and without fermichem, we will be in a prime position to get more players and be newbie friendly.