BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

Ports the ssd indicators from..skyrat

Open etherware-novice opened this issue 2 years ago • 13 comments

About The Pull Request

https://github.com/Skyrat-SS13/Skyrat13/pull/420 nice https://github.com/Skyrat-SS13/Skyrat13/pull/615

skyrat may be infamous but it does have a few good ideas so you get an ssd indicator on you when you go ssd

Why It's Good For The Game

Useful for telling at a glance wheter someone is actually ssd, INFINITELY useful for the ai as they cant examine people

Testing Photographs and Procedure

Screenshots&Videos

image

Changelog

:cl: add: ssd indicators /:cl:

etherware-novice avatar Sep 03 '22 07:09 etherware-novice

Not tweak. It is add.

EvilDragonfiend avatar Sep 03 '22 07:09 EvilDragonfiend

Does the indicator remain if you change their clothes?

PowerfulBacon avatar Sep 03 '22 08:09 PowerfulBacon

why would changing equips affect this

etherware-novice avatar Sep 03 '22 15:09 etherware-novice

Since its based on directly adding to overlays rather than using add_overlay, clothing is all done by overlays which will be updated when using add_overlay or remove_overlay. Directly adding to overlays means it won't be managed by the overlay system which you get if you use add_overlay instead

PowerfulBacon avatar Sep 03 '22 18:09 PowerfulBacon

indicator continues towork

etherware-novice avatar Sep 03 '22 18:09 etherware-novice

A fine addition to my collection!

If possible, perhaps have different icons depending on how they are disconnected, like green if the player is AFK but is still connected, yellow for a sudden disconnection, red for if the player had properly left the game or if its a case of soul departed/DNR. I know this would be a lot to ask for, but it'd be super helpful to know if there's a possibility of the player comming back or if we are wasting our time by having a catatonic person in med for the purposes of cryoing them as med or how a suspected traitor should be handled if they suddenly go SSD as a security officer.

FortSumter avatar Sep 03 '22 20:09 FortSumter

well idk how to test the different disconnects but sure i can do a red for dnr

etherware-novice avatar Sep 03 '22 20:09 etherware-novice

nvm i dont understand this

etherware-novice avatar Sep 03 '22 23:09 etherware-novice

Honestly a nice idea, i saw it before and i think it's very useful even in some scenarios where you can go ''oh they're ssd i'll come back later to them''

Fronsis avatar Sep 04 '22 04:09 Fronsis

It's okay if you can't do what I suggested; I'm not sure if what I suggested is even possible. I just thought it would be insanely helpful if you could use this to tell not only when someone is SSD, but also be able to judge whether they might come back at all depending on how they disconnected. I know the server keeps track of a disturbingly large amount of meta data and so I was hoping it logged disconnects in a way to make my idea possible.

FortSumter avatar Sep 04 '22 14:09 FortSumter

you ported the Skyrat Cit versions of our SSD indicators, I recommend checking 1325 to make sure it matches (along with porting 1801 and 1908) since the skyrat TG version (linked) is slightly more recently made

Zonespace27 avatar Sep 06 '22 06:09 Zonespace27

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 25 '22 05:09 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 03 '22 15:10 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 11 '22 06:10 github-actions[bot]