BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

[TG PORT] Space Dragon Rework

Open itsmeow opened this issue 1 year ago • 7 comments

About The Pull Request

Ports:

  • https://github.com/tgstation/tgstation/pull/49344 (big)
  • https://github.com/tgstation/tgstation/pull/50196
  • https://github.com/tgstation/tgstation/pull/50932
  • https://github.com/tgstation/tgstation/pull/53944
  • https://github.com/tgstation/tgstation/pull/54124 (medium)
  • https://github.com/tgstation/tgstation/pull/54774 (just the space dragon fix)
  • https://github.com/tgstation/tgstation/pull/55759
  • https://github.com/tgstation/tgstation/pull/57428 (just the IDEA, heavily modified since our code is completely different)
  • https://github.com/tgstation/tgstation/pull/57942 (medium, gust is not a right-click, since we don't have that)
  • https://github.com/tgstation/tgstation/pull/58392
  • https://github.com/tgstation/tgstation/pull/60058
  • https://github.com/tgstation/tgstation/pull/60259 (big nerfs)
  • https://github.com/tgstation/tgstation/pull/65311 (thanks ivan)
  • https://github.com/tgstation/tgstation/pull/67630

Includes additional dynamic tweaks to the space dragon midround that is added in 49344 from https://github.com/tgstation/tgstation/pull/65997 and https://github.com/tgstation/tgstation/pull/68571

See original PRs for changes.

Includes some additional changes:

  • Had to rework the ritual claw which used tail sweep, now it just uses the xeno one instead

Why It's Good For The Game

The old space dragon is really bad and just has to gib a random head, then be killed by everyone or gib random people to survive. Bad murderbone weird space dragon. This gives it actual unique objectives that are interesting and fun to fight.

Testing Photographs and Procedure

Screenshots&Videos

https://user-images.githubusercontent.com/10366817/184504878-a7acfb56-7a7e-4d1c-8476-a7f759466258.mp4

Changelog

:cl: itsmeow, Indie-ana Jones, redguy999, Timberpoes, Ryll-Ryll, Ghommie, read-0nly, ivanmixo, JohnFulpWillard refactor: The Space Dragon has totally new objectives where it can spawn rifts that summon sentient space carp, and must defend the rifts until three are created, flooding the station with infinite sentient carp and auto-calling the shuttle. add: Space Dragon is now a ruleset in dynamic as well as a station event. tweak: Space Dragons can now set their name and color. add: Space Dragon now has its own death sound. tweak: Space Dragon roar is now quieter. /:cl:

itsmeow avatar Aug 13 '22 17:08 itsmeow

Do note some of the later PRs change major stuff about this, so don't review the idea yet. Another PR that will be ported removes the shuttle-calling part.

itsmeow avatar Aug 13 '22 17:08 itsmeow

tbh I would rather have a murderbone midround than what's effectively another blob

ToasterBan avatar Aug 13 '22 20:08 ToasterBan

I would also like to keep the dragon as being a murderbone antag. Most of what the main PR you're porting seems fine to me although I don't think it solves any of the problems with it the original author wanted to fix with it... The main bit I like is that it no longer Gibs people as that was the most shitty aspect of the antag from the crew perspective.

as for the port of #65997.... don't do it. Other PRs have come out recently making massive overhauls with dynamic mode and we've yet set dynamic to be the default like Tg has. Midrounds are fairly rare already and I'd rather not have even more people fucking with the code until we can determine if the changes already made were any good.

FortSumter avatar Aug 13 '22 22:08 FortSumter

@FortSumter I already ported 65997... This just includes the addition FROM that to the space dragon. See #7438

itsmeow avatar Aug 13 '22 22:08 itsmeow

do you guys play on /tg/ hes still a murderbone antag

blob is a very weird comparison, just because they both defend things dont make them the same. They play distinctly enough

Sinestia avatar Aug 13 '22 23:08 Sinestia

Yeah, okay, clarifying. This is still a lavaland escalation antag. It just has more interesting and unique objectives, and also provides further ghost roles in the form of sentient carp. It's more fun for everyone involved IMO as the current dragon metas are: try to RP and be friends with crew, and then kill your target right at the end for le troll OR kill everyone so they can't kill you

Neither of these are fun or unique. The carp rift objectives feel very different than anything else in the game while also focusing far less on murdering random crew for health or killing a random head. Now the dragon has an objective that feels more in line with its lore and actually makes sense.

itsmeow avatar Aug 14 '22 04:08 itsmeow

This is still a lavaland escalation antag

I'm fairly certain it's a murderbone escalation antag, if it were lavaland escalation it wouldn't be allowed to attack first.

It's not technically in the escalation list from what I can see but yeah

Sinestia avatar Aug 14 '22 14:08 Sinestia

Please see the newer dragon rework PRs. It's no longer a shuttle call

See tg #57942

itsmeow avatar Aug 17 '22 19:08 itsmeow

The bit about this I don't like is the carps. When we used to have devils, the antag itself was actually super fun from an RP perspective. The fun suddenly stopped however when the devil "won" by achieving their final form and uncontrollably started spawning an unending tide of imps that would murderbone the crew their devil master had befriended or at least had a vested interest in since most of them were people they signed contracts with.

I'm concerned that any attempt to roleplay as the dragon or with them wouldn't be possible due to the dragon being unable to control what the carps do.

FortSumter avatar Aug 17 '22 23:08 FortSumter

New space dragon isn't really supposed to RP aside from the "you're on my turf, get out of my way" type deal. It has a job to do, like a blob or nightmare. You don't really reason with it.

itsmeow avatar Aug 18 '22 01:08 itsmeow

Correction: It does actually spawn non-sentient carp if there are no ghosts to take the role.

HOWEVER, it only does this every 30 seconds.

itsmeow avatar Aug 18 '22 02:08 itsmeow

Well that's good at least.

Also not sure why I would have to remind you, but this is a hug box medium roleplay server where antags aren't allowed and neither is anything else fun. The headmins get upset when the antags don't RP and making an antag less RP and more murderbone makes them cry.

FortSumter avatar Aug 18 '22 05:08 FortSumter

I mean, this dragon has a better reason for existing RP-wise, even if it has less actual RP. But honestly, there isn't much fun about the current space dragon RP meta where you just sort of either completely ignore your objectives to RP or you pretend to be nice and then murder heads of staff, and then end up having to gib people just to heal.

This at least has some unique lore and reason for existing, doesn't have to gib people, is more engaging for all players, and provides a unique threat. It also provides more ghost roles and the opportunity for space dragon statics.

itsmeow avatar Aug 18 '22 05:08 itsmeow

Ignoring the objectives is just the way for antags now. You get nothing for doing them besides the satisfaction of a greentext and ruko has been an advocate of removing that too. You'd think we'd put some, really any effort at all to making solo antags into a better experience considering them doing things is absolutely integral almost every department having things to do beyond the first 5 minutes.

FortSumter avatar Aug 18 '22 16:08 FortSumter

antags drive rounds, if antags don't do things the game gets stale and boring. This is universally agreed. I don't know what you are complaining about, no one is really against this improvement or has said anything negative related to the rp changes.

ignoring objectives is fun to suit gimmicks, but generally if you don't have a plan, doing them is a good idea.

We already removed the beecoin bonus for greentexting to encourage less stealth-antagging and more fun RP.

Is this not the effort being put into making solo antags better?

I am just confused what you are complaining about.

itsmeow avatar Aug 18 '22 18:08 itsmeow

bumpy pls review or TM

itsmeow avatar Sep 10 '22 02:09 itsmeow

my poor baby, unloved for more than a month

itsmeow avatar Sep 27 '22 21:09 itsmeow

Carps can die from space dragon breath

itsmeow avatar Oct 11 '22 01:10 itsmeow

Extended TM for balance testing. If you're in a round with it please leave comments.

itsmeow avatar Oct 19 '22 17:10 itsmeow

Might be a good idea to add the rifts to the orbit or spawner menus

ro5490 avatar Oct 23 '22 03:10 ro5490

When a Space Dragon tries a tail sweep, they become frozen. They can't move or do something else, and their animation is frozen too.I don't know if it's because of the tail sweep, but It seems.

itsmeow avatar Oct 23 '22 18:10 itsmeow

need to look at https://github.com/tgstation/tgstation/pull/70522

itsmeow avatar Oct 27 '22 09:10 itsmeow

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 30 '22 11:10 github-actions[bot]

purgatory

itsmeow avatar Dec 04 '22 10:12 itsmeow

I would prefer at this point this just be merged and any balance issues can be worked out. I firmly believe it is still a solid improvement over the original Space Dragon.

itsmeow avatar Jan 22 '23 10:01 itsmeow