BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

MRat V2

Open itsmeow opened this issue 1 year ago • 6 comments

About The Pull Request

Re-PR of https://github.com/BeeStation/BeeStation-Hornet/pull/5270

Ports

  • https://github.com/yogstation13/Yogstation/pull/11876
  • https://github.com/yogstation13/Yogstation/pull/11881
  • https://github.com/yogstation13/Yogstation/pull/11894
  • https://github.com/yogstation13/Yogstation/pull/11951

Added some more types - kitten, fixed the corgi type, slime puppy, butterfly, mothroach, crab, and hamster.

Changed the bee sound from very loud buzzing to the beloved moth_scream.ogg

Mrats can also pick a name when created instead of having it just be their CKEY. The CKEY is still in the name, but after.

Bee sprite credits to Gilgax

Why It's Good For The Game

Mentors can be more useful (BOOM DOG!!!)

Testing Photographs and Procedure

Screenshots&Videos

image

image

image

image

Changelog

:cl: itsmeow, Ivniinvi, ynot01 add: You can now request mentor assistance, in the form of an imaginary ghostly rat. tweak: Imaginary friends now have a message in chat when pointing. /:cl:

itsmeow avatar Aug 05 '22 14:08 itsmeow

The new ensemble image image

Side note: I removed the blue coloring from everything except the mouse, hamster, and butterfly, since those sprites are white it works better.

itsmeow avatar Aug 06 '22 21:08 itsmeow

Replaced my patch-on fix with a PR. Merge this first. https://github.com/BeeStation/BeeStation-Hornet/pull/7462

itsmeow avatar Aug 08 '22 10:08 itsmeow

Mentor rats can still use LOOC but IC they are imaginary friends. I could remove the CKEY from their names if needed.

itsmeow avatar Aug 09 '22 10:08 itsmeow

I don't know if you can put gifs in here but just imagine the penguinz0 gif here you know the one the "wooooooo baby this is what we've been waiting for" one

RDS88-beeman avatar Aug 09 '22 20:08 RDS88-beeman

image

itsmeow avatar Aug 09 '22 20:08 itsmeow

thank you

RDS88-beeman avatar Aug 09 '22 20:08 RDS88-beeman

Crossed requested a TM

itsmeow avatar Sep 04 '22 18:09 itsmeow

Mrat should have some form of mind-to-mind communication for questions about private stuff Mrats shouldn't really be clickable (pass-through?)

itsmeow avatar Sep 04 '22 21:09 itsmeow

All of these are issues with imaginary friends, not mrats

Except for

Also the host can't get rid of the mentor

itsmeow avatar Sep 04 '22 21:09 itsmeow

Just tried it out. Bacon already mentioned it but the sprite rotation seems janked. It seems moving around doesn't change it, and shift clicking/control+direction is the only way to change your sprite orientation but it only comes into effect AFTER you move? The mind to mind communication being brought up is because the mentoree cant hear everything mrats say but not the other way around, notebly behind walls for exemple. And the lack of overhead chat's already been brought up as well. Oh and I almost forgot: could you lower the sound the mrat makes on each message (atleast for the mrat themselves)? The actual rat is bearable, but listening to the moff scream that many times was a bit much.

Gilgaxx avatar Sep 04 '22 21:09 Gilgaxx

The sounds only existed afaik due to the lack of overhead chat, so I might end up removing that if I add overhead chat.

The facing thing is also an issue with imaginary friends, but honestly I kind of like it - it makes it seem more like you're floating around and a magical being when walking right doesn't make you actually turn - it gives you full control over the turning. I could make turning apply before you move though.

itsmeow avatar Sep 04 '22 22:09 itsmeow

Okay, as it is, this PR is GTM.

Imaginary friends need improvements in a separate PR.

itsmeow avatar Sep 11 '22 08:09 itsmeow

A large majority of issues addressed in #7674

itsmeow avatar Sep 11 '22 10:09 itsmeow

maintainers ignore mrats challenge (easy mode)

itsmeow avatar Nov 01 '22 07:11 itsmeow

actually impossible to merge PR

itsmeow avatar Nov 18 '22 11:11 itsmeow