BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

Creates a Janitor Bluespace Light Replacer

Open etherware-novice opened this issue 1 year ago • 24 comments

About The Pull Request

The janitor is now getting a second bluespace upgrade! The bluespace light replacer is researchable under Advanced Sanitation Tech, and works similar to the Bluespace RPED. Just point at a broken light and click, and it gets replaced on the fly!

And because having an upgraded and weaker version of the same thing in the same node would be weird, I'm also moving the base light replacer to be a round-start item.

Why It's Good For The Game

Lights inside of departments rarely get replaced, due to the hassle of getting people to let you in for such a small thing. This change makes it MUCH easier for janitors to replace lights in restricted areas, as if theres a window you can just shoot the lightbulb back on.

Testing Photographs and Procedure

Screenshots&Videos

lightrep

(new sprite)

light_base

light_new

https://user-images.githubusercontent.com/73374039/182002944-263350e6-8df9-42a8-9f40-95f63bc249a3.mp4

Changelog

:cl: add: Added the bluespace light replacer tweak: Moved the standard light replacer to a round-start item /:cl:

etherware-novice avatar Jul 30 '22 23:07 etherware-novice

sprite looks a bit weird, but I like the concept.

EvilDragonfiend avatar Jul 31 '22 07:07 EvilDragonfiend

Surely this cannot be used to make entire station unhabitable remotely right ?

FriendlyContractor avatar Jul 31 '22 08:07 FriendlyContractor

hm?

etherware-novice avatar Jul 31 '22 13:07 etherware-novice

tweak: Moved the standard light replacer to a round-start every departmental lathe item

This should still only be a part of engineering and janitorial department lathes.

itsmeow avatar Jul 31 '22 17:07 itsmeow

but why are light replacers restricted to those two in the first place

etherware-novice avatar Jul 31 '22 17:07 etherware-novice

Part of playing the game and interacting with others is asking for access to departments, whether it be the workers there or the AI. Encouraging everyone to play isolated job simulator is not good, if your job requires going to other departments, then you can ask HoP, AI, or someone in that department for access instead.

Now everyone will just print light replacers and replace their own departments, which gives engineers/janitors even less job to do when usually they're already pretty under-worked. The bluespace one is a good addition because it allows janitors to replace lights with less access-wrangling, but letting other crew do it themselves just removes part of the game.

itsmeow avatar Jul 31 '22 17:07 itsmeow

oh

etherware-novice avatar Jul 31 '22 17:07 etherware-novice

oh god damnit indentation error again

etherware-novice avatar Jul 31 '22 18:07 etherware-novice

I was hoping it will be obvious for others how this is extremely exploitable and can be very easily used to grief the entire round but nobody pointed it out yet so i better say it out loud least this gets merged.

Lightbulbs can be injected with 5u of plasma to make them rigged which causes them to explode and create plasma fire when powered. Normally this is fine since you need to turn off the light first or you will be the one blown up limiting its uselfullnes HOWEVER with bluespace device you can do this remotely through camera console and cause explosions and plasma fires everywhere there are lightbulbs and cameras.

FriendlyContractor avatar Jul 31 '22 18:07 FriendlyContractor

you can inject lights with plasma?!

etherware-novice avatar Jul 31 '22 18:07 etherware-novice

I hope i am wrong but im getting a feeling this is malcious PR trying to intentionally introduce game breaking exploit

FriendlyContractor avatar Jul 31 '22 19:07 FriendlyContractor

i didnt know about the plasma lights!

etherware-novice avatar Jul 31 '22 19:07 etherware-novice

I hope i am wrong but im getting a feeling this is malcious PR trying to intentionally introduce game breaking exploit

Nothing about this or any other their PR looks like malice in my opinion, why jumping to such conclusions right away?

But yeah, despite the dumbass malice accusation, they have a point, you shouldn't be able to remotely replace lightbulbs with plasma filled ones.

Mat05usz avatar Jul 31 '22 20:07 Mat05usz

ill just make it unemaggable

etherware-novice avatar Jul 31 '22 20:07 etherware-novice

ill just make it unemaggable

It's not about emag, you can inject plasma into a lightbulb, then place it inside the replacer and use it like that.

Mat05usz avatar Jul 31 '22 20:07 Mat05usz

oh..

etherware-novice avatar Jul 31 '22 20:07 etherware-novice

I'm not sure about the best way to solve this, maybe just make it unable to accept rigged flashbulbs?

Mat05usz avatar Jul 31 '22 20:07 Mat05usz

hey wait it doesnt even use the same light thing i think it just adds to a int of lights

etherware-novice avatar Jul 31 '22 20:07 etherware-novice

I don't see how would you use this to create plasma-fires through cams and it's kinda rude to straight up accuse OP for trying to make an exploit???

Sure, if you do it with a regular lightbulb in-hand you can do the plasma trick but i don't think you can inject plasma into the light replacer itself meaning that all those bulbs/tubes can't be injected pre-placing them since they exist within the light replacer, unless you can inject plasma to the light replacer itself which.. it would be kinda weird but i guess it could be fixed to not being able to do so.

Fronsis avatar Jul 31 '22 22:07 Fronsis

I don't see how would you use this to create plasma-fires through cams and it's kinda rude to straight up accuse OP for trying to make an exploit???

Sure, if you do it with a regular lightbulb in-hand you can do the plasma trick but i don't think you can inject plasma into the light replacer itself meaning that all those bulbs/tubes can't be injected pre-placing them since they exist within the light replacer, unless you can inject plasma to the light replacer itself which.. it would be kinda weird but i guess it could be fixed to not being able to do so.

you can make plasma filled lights by emagging the light replacer, so i just made it un-emaggable

etherware-novice avatar Jul 31 '22 22:07 etherware-novice

I thought you can fill lights and then put them into the device?

Mat05usz avatar Aug 01 '22 20:08 Mat05usz

does it?? i didnt see anything like that in the code

etherware-novice avatar Aug 01 '22 20:08 etherware-novice

I thought you can fill lights and then put them into the device?

Never really tried that since i just recharge it with Glass, that's the main point of the light replacer tbh

So the BS Light replacer can't be emagged but the regular stays emaggable? if so that's good

Fronsis avatar Aug 01 '22 21:08 Fronsis

yea, only the bluespace varient is emag proof

etherware-novice avatar Aug 01 '22 22:08 etherware-novice