VIP gets their own department budget than the civilian budget, and gets paid from it. (+department account lock feature)

[EvilDragonfiend]

About The Pull Request

VIP gets payment from their own department budget than the civilian budget also, minor fix to cargo ordering app(tablet) along with the new feature

and department lock feature - VIP, Captain, HoS will not get their primary payment department changed. VIP is always from NT budget, Cap and HoS is always from security budget regardless of their newly assigned department. CMO/CE/RD is still changed because they should see the security budget when they're acting.

Why It's Good For The Game

If HoP and Captain are mean and clever enough, they decrease VIP payment. It's cheating VIPs. This PR protects VIPs so that they do not lose their wealth. 250 credits aren't enough to flex their real wealth, so some buff to them to 2000 credits since they don't leach station budget anymore. Let's give them REAL WEALTH AND FLEX!

For the credit size, I haven't actually felt they're really wealthy, so 2000 credits would look too much, but I believe they deserve it when we consider they are so special.

department lock feature is just a new feature that follwed after VIP budget thing. actually, it's not that bad to apply it to Captain and HoS, since their paycheck department will be never changed.

Testing Photographs and Procedure

Screenshots&Videos

VIP card says The Nanotrasen VIP Expense Account Budget

---

payday is fine

---

This card exists in the code but is spawned in nowhere. only admin can spawn it.

---

even if their department is changed, it still is in VIP budget.

---

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

VIP No paycheck in HoP console

---

cargo ordering app doesn't accept VIP department budget. no bypass.

Changelog

:cl: add: Nanotrasen VIP Expense Account Budget has been added. VIPs will be paid from this budget directly from Nanotrasen rather than the station budget. tweak: Station heads can't change VIP's payment anymore. (but they can't give bonus to them also.) tweak: VIP bank accounts are all fixated to Nanotrasen VIP budget department, and changing department will not change their assigned department. tweak: VIP payment is now 2000 credits, and roundstarts with 10000 credits tweak: VIP mail from cargo is now yellow refactor: cargo ordering app through a tablet will not accept improper id card tweak: department change lock feature - even if you change your department, some jobs (VIP, Captain, HoS) don't have a newly changed department as your bank account paying department. /:cl:

[itsmeow]

+1 giving VIPs the Nanotrasen special treatment they've always dreamed of

[Fronsis]

We might've removed their bridge access.. but they will NEVER lose money!

[EvilDragonfiend]

need to fix pirate siphon thingie

[EvilDragonfiend]

possible bugs/exploits are now fixed

[EvilDragonfiend]

department account lock is more detailed than before.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[mystery3525]

The only problem I have with this is that they should be lowered to maybe 500 credits per paycheck, they still are the best paid person on the station, but they can't just privately buy riot shotgun crates ten minutes into the round

[EvilDragonfiend]

The only problem I have with this is that they should be lowered to maybe 500 credits per paycheck, they still are the best paid person on the station, but they can't just privately buy riot shotgun crates ten minutes into the round

meanwhile everyone is highly possible to use budget card under the approval of their heads, VIP is not likely acceptable for that. so I wanted to compensate them for their role. and VIP buying some lethal stuff would look suspicious enough. you still need access to unlock it, or emag it.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[EvilDragonfiend]

Someone will 100% find a way to exploit this.

I don't believe so.

There's probably some weird way by setting the account ID of a job card with an insanely high paycheck to the account of the VIP

uh, okay, I will describe all possible situations.

1. Using budget directly from their budget account It 'was' possible since the cargo ordering app was broken in code. actually, I don't think it's still working as intended. anyway, It was the only possible way to make a glitch for the budget card.

2. Gets VIP budget card and pulls money out from it VIP budget card spawned in nowhere. not possible. Only admin thing like debug stuff.

3. CentCom gives more paycheck to VIP It was possible before the last pull update(As CC ID card), but I removed it since an admin just can adjust their paycheck by variable edit if they want. So, even ICly, It's not possible that anyone can decrease/increase VIP paycheck

4. VIP leaches other department budget once their department is changed department_locked exists to prevent that. Not possible

5. Station crews leach the VIP budget It's not possible to have ACCOUNT_VIP department paycheck from anywhere unless they're a spawned VIP.

6. Steals VIP budget with some weird way...? ??? I don't think it's possible.

7. Steals VIP level payment value from their bank account and apply the value to the normal crew's paycheck value I think this is what you're talking about, but It's not how a bank account code works. paycheck value is stored in their bank account, and it's only editable by HoP console. If they can change it through HoP console, they literally deserve it. Of course, VIP paycheck value is fixated, and It's stated in number 3.

[EvilDragonfiend]

or I can put a tracking method to check if VIP budget was incorrectly used

[Penwin0]

I don't believe so.

HoP console can edit paychecks, is it protected against this?

[EvilDragonfiend]

I don't believe so.

HoP console can edit paychecks, is it protected against this?

Absolutely protected. Adjusting payment needs a departmenr head access(medics to cmo, secs to hos) but VIP one has no superior access to edit their payment. which means only admin var edit is available to adjust theirs