BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

[Bounty] Get our bodyparts/limbs/organs up to date with TG limbs.

Open PowerfulBacon opened this issue 2 years ago • 3 comments

Summary

Kapu updated the limbs with some newer code, however this introduced a large number of bugs that require fixing. This was going to be a simple bounty to fix the hair bug, however our code is so outdated from TG that it should just be fully updated to get all of the improvements they have done.

This bounty is for $100

Tasks

  • Update the limbs to be completely up to date with TG's limbs.
  • Remove any unnecessary TG code
  • Add any Bee specific code that isn't on TG
  • Test the PR with beecode (Make sure stuff like magic mirror works and people aren't bald anymore)
  • Handle any reviews required

Potentially Relevant PRs

There may be more that I missed, but this is everything that I could find. Some stuff may be TG specific

https://github.com/tgstation/tgstation/pull/65523 (Major) https://github.com/tgstation/tgstation/pull/67017 (Major) https://github.com/tgstation/tgstation/pull/65887 https://github.com/tgstation/tgstation/pull/65923 https://github.com/tgstation/tgstation/pull/66065 https://github.com/tgstation/tgstation/pull/66704 https://github.com/tgstation/tgstation/pull/65904

https://github.com/tgstation/tgstation/pull/66607 https://github.com/tgstation/tgstation/pull/67436 https://github.com/tgstation/tgstation/pull/67104

I think these ones should be, but they might contain only TG specific content: https://github.com/tgstation/tgstation/pull/67450 https://github.com/tgstation/tgstation/pull/67532 https://github.com/tgstation/tgstation/pull/68094 https://github.com/tgstation/tgstation/pull/66103 (Not sure if we removed this too) https://github.com/tgstation/tgstation/pull/66112

https://github.com/tgstation/tgstation/pull/68045

PowerfulBacon avatar Jul 06 '22 18:07 PowerfulBacon

~~can do this~~ sorry, nevermind can't do this. i forgot i have many PRs to do already

Dejaku51 avatar Jul 06 '22 18:07 Dejaku51

I can do that

Archanial avatar Jul 09 '22 16:07 Archanial

I have a question, what does kapulimbs give to a player and why are we spending 100$ on fixing it?

Mat05usz avatar Aug 12 '22 22:08 Mat05usz

I have a question, what does kapulimbs give to a player and why are we spending 100$ on fixing it?

you don't get a say, sorry

Iamgoofball avatar Aug 15 '22 23:08 Iamgoofball

I have a question, what does kapulimbs give to a player and why are we spending 100$ on fixing it?

This is a very large amount of work to complete, $100 isn't a lot considering normal developer pay but its hopefully an incentive for anyone consider doing it to prioritise working on this (SS13 in general doesn't bring a lot of income in, so paying decent rates is challenging, plus we wouldn't really want to get people coding strictly for the money who won't maintain things in the future).

PowerfulBacon avatar Jan 31 '23 18:01 PowerfulBacon

@Archanial Are you still working on this?

PowerfulBacon avatar Jun 16 '23 11:06 PowerfulBacon

Judging by its been over a year, I take it this is no longer being actively worked on.

PowerfulBacon avatar Jun 16 '23 11:06 PowerfulBacon

I did partially fix one of the bugs here https://github.com/BeeStation/BeeStation-Hornet/pull/8926

itsmeow avatar Jun 22 '23 21:06 itsmeow