BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

Refactors bruise packs and ointment, with a mild rebalance to them and patches added

Open ivanmixo opened this issue 2 years ago • 4 comments

About The Pull Request

Makes bruise pack/ointment/gauze code less sucky. You also can't use them on stuff that isn't hurt anymore, nice.

You can't stack the do_afters anymore when using them. This means you can't outheal space anymore by stacking the bars.

The area of the body you're targeting when applying a patch/medspray now actually matters. The reaction_mob proc will try to use the limb you're targeting as the limb it'll apply the instant damage healing property to when loaded with chems like styptic powder/synthflesh/silver sulf.

Killed off the useless do_after_mob proc and replaced all instances with do_mob

Why It's Good For The Game

Better code gooder, bruise packs and ointment being slightly less OP also good.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

image

image

image

image

image

image

Applied 30u synthflesh to chest.

image

Changelog

:cl: balance: bruise pack/gauze/ointment application do_afters(the use bars) can't be stacked on yourself anymore yet fix: you can't apply gauze on people who arent hurt anymore del: useless do_after_mob proc refactor: refactored bruise pack/ointment/gauze application proc balance: the area of the body you're targeting when applying touch based healing reagents through a patch/medspray now actually matters /:cl:

ivanmixo avatar Jun 29 '22 14:06 ivanmixo

I like this, it might incentivise actually making styptic powder and silver sulf patches instead of hee hoo ointment and bruise packs

Coding-Grape avatar Jun 30 '22 02:06 Coding-Grape

Is making docs and refactoring the parent of the main subject of the thing I'm refactoring really going to hurt?

Update the PR body to say what you are doing then. Refactoring is fine if you say what you are actually changing

PowerfulBacon avatar Aug 01 '22 18:08 PowerfulBacon

Status of this PR? Requested changes implemented?

itsmeow avatar Aug 08 '22 16:08 itsmeow

Status of this PR? Requested changes implemented?

I disputed the reviews I disagreed with and implemented the suggestions

ivanmixo avatar Aug 09 '22 11:08 ivanmixo