BeeStation-Hornet
BeeStation-Hornet copied to clipboard
BeeStation
Mentor code is tragic
Mentor code is straight up from hippie. Not only it's existence breaks the rules of our repo (no hippie ports) it also barely works and randomly runtimes.
Mentors should be subtype of admin with only R_MENTOR given to them. That way we could reuse the ahelp ticket menu to make mhelps a tickets which a mentor could claim, respond etc.
Not only would it make mentors actually logged but also it would allow for future expansion of mentor rights and future features (mentor ghost? mentor pets?).
The ahelp feature should also be somewhat modified to allow players to make either ahelp or mhelp depending on their choice or preference.
Mentors should be able to "elevate" mhelp tickets to ahelp tickets for admins to handle then and the admins should be able to do the opposite for ahelp tickets.
Also the mentor sql table should be dropped and already existing table for admins should be reused. The challenge here is reworking admins in the way, they would support "lower" rank non-admin staff (mentors!) and, while the ticket ui stays the same for both, it shouldn't display ahelp tickets to non-admin staff members.
If someone actually wants to recode mentors every trace of current mentor code should be purged first and every rework/expansion whatever should not take any code from our existing code.
Could start following the fulp way of mentors (as a baseline)
- Removing that weird "Memo" shit that does nothing, general mentor port - https://github.com/fulpstation/fulpstation/pull/6
- Part 2 - https://github.com/fulpstation/fulpstation/pull/24
- QoL - https://github.com/fulpstation/fulpstation/pull/51
- Logging - https://github.com/fulpstation/fulpstation/pull/185
- Admin stuff - https://github.com/fulpstation/fulpstation/pull/410
- URLs and pings - https://github.com/fulpstation/fulpstation/pull/455
idc do what you want
Those are nice bandaids but I feel like mentor is too shitty to keep fixing. Full rewrite is just easier.
Those are nice bandaids but I feel like mentor is too shitty to keep fixing. Full rewrite is just easier.
If it's "easier" then why hasn't there been any PRs?
Methinks it would be easier to just apply the 'bandaids'.
