BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

[Port] Emote Update

Open XeonMations opened this issue 4 months ago • 1 comments

About The Pull Request

Ports the following TGstation PRs:

  • [x] https://github.com/tgstation/tgstation/pull/44458
  • [x] https://github.com/tgstation/tgstation/pull/68948
  • [x] https://github.com/tgstation/tgstation/pull/74940
  • [x] https://github.com/tgstation/tgstation/pull/75253
  • [x] https://github.com/tgstation/tgstation/pull/75345
  • [x] https://github.com/tgstation/tgstation/pull/78711
  • [x] https://github.com/tgstation/tgstation/pull/79216
  • [x] https://github.com/tgstation/tgstation/pull/79481
  • [x] https://github.com/tgstation/tgstation/pull/80522
  • [x] https://github.com/tgstation/tgstation/pull/80601
  • [x] https://github.com/tgstation/tgstation/pull/80688
  • [x] https://github.com/tgstation/tgstation/pull/81883
  • [x] https://github.com/tgstation/tgstation/pull/82748
  • [x] https://github.com/tgstation/tgstation/pull/82832
  • [x] https://github.com/tgstation/tgstation/pull/83283

Added sounds are from Sadboysuss's https://github.com/tgstation/tgstation/pull/82748 PR, as well as freesound.org. Attributions added where able.

male_giggle_1.ogg through male_giggle_3.ogg sourced from: https://freesound.org/people/SnowFightStudios/sounds/643665/ , license of CC0 1.0

Why It's Good For The Game

Proper functionality of emotes is nice to have, being able to hear custom emotes while deaf is also quite critical, as you are.. deaf. Also having a proper window for all the emotes and what they're like is good.

Testing Photographs and Procedure

Screenshots&Videos
Emote Menu

image

https://github.com/user-attachments/assets/be1f4766-27bd-43e4-96e0-ce47b09a4813

https://github.com/user-attachments/assets/ab355a10-76f8-4c92-8fa9-1c4c6e21e768

https://github.com/user-attachments/assets/6278d8d4-a2cb-479b-9c1e-00ef1d7db49a


Tested speech in order: Test. Test| ;Test ;test|

image

Testing|testing image testing|testing image


https://github.com/user-attachments/assets/aaafe9eb-d9b1-48d5-ab5a-bca0eec1a27d

Changelog

:cl: AnturK, Mooshimi, nikothedude, lebedev, kawoppi, RunKitenzRComing, DrDiasyl, larentoun, Mothblocks, jlsnow301, MrMelbert, Sadboysuss, XeonMations fix: Fixed custom emotes not showing up when a person is deaf. qol: Added a TGUI emote menu that shows every emote to the IC tab. refactor: Refactored some emote code. qol: You can now see people doing emotes that require sight without hearing. qol: You can now hear people doing emotes that require hearing without sight. add: People wearing a security mask now have a special deathgasp. add: Added *smirk emote. add: Added *sweat, which is the same as *sweatdrop. /:cl:

XeonMations avatar Oct 02 '24 03:10 XeonMations