BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

[Port] TGUI Records, attempt 2

Open XeonMations opened this issue 5 months ago • 12 comments

About The Pull Request

Originally https://github.com/BeeStation/BeeStation-Hornet/pull/11126, old one became stale, so here we are, now that the department refactor went through.

TGUI-ifies the security, medical and general manifests.

Ports:

  • [x] https://github.com/tgstation/tgstation/pull/72725
  • [x] https://github.com/tgstation/tgstation/pull/73022
  • [x] https://github.com/tgstation/tgstation/pull/73084
  • [x] https://github.com/tgstation/tgstation/pull/73363
  • [x] https://github.com/tgstation/tgstation/pull/73666
  • [x] https://github.com/tgstation/tgstation/pull/73882
  • [x] https://github.com/tgstation/tgstation/pull/75320
  • [x] https://github.com/tgstation/tgstation/pull/76760
  • [x] https://github.com/tgstation/tgstation/pull/77800
  • [x] https://github.com/tgstation/tgstation/pull/78516
  • [x] https://github.com/tgstation/tgstation/pull/78528
  • [x] https://github.com/tgstation/tgstation/pull/80692
  • [x] https://github.com/tgstation/tgstation/pull/82103
  • [x] https://github.com/tgstation/tgstation/pull/82105
  • [x] https://github.com/tgstation/tgstation/pull/83740
  • [x] https://github.com/tgstation/tgstation/pull/85733

Partial ports:

  • [x] https://github.com/tgstation/tgstation/issues/66607 - icons,dm /proc/generate_icon_alpha_mask()

Fixes https://github.com/BeeStation/BeeStation-Hornet/issues/11095

Why It's Good For The Game

Using old ass menus for records is debilitating when it doesnt even show pictures half the time. Newish system shouldnt have that issue anymore.

Testing Photographs and Procedure

Screenshots&Videos ---
Security Records

Logging in and out of security records:

https://github.com/user-attachments/assets/4b3209cb-e252-4876-b277-269f69e7aed1

Logging in requires access:

https://github.com/user-attachments/assets/389c367f-aeff-4006-b284-f4230ee1574e

Security records function as expected:

https://github.com/user-attachments/assets/4b088884-4af1-4da7-b15a-1bd60bf1ff79

Deleting and purging records (sechud issue was resolved in a571bd0):

https://github.com/user-attachments/assets/de6dc173-900f-487d-8b82-096405d57afe

Printing:

https://github.com/user-attachments/assets/1bfe7954-91fd-4c6c-ad02-f64204b7b928

Adding and updating records:

https://github.com/user-attachments/assets/c982c2fc-fbe2-44f3-a5c8-338d01c2f016


Medical Records

Logging in with and attempting to log in without access:

https://github.com/user-attachments/assets/3d8e6b8a-d2bd-4d1e-bb9e-30e042280760

Medical records work as expected:

https://github.com/user-attachments/assets/f396c3b5-8141-4b81-973d-dce79c9e0c12

Expunging and purging records works as expected as well:

https://github.com/user-attachments/assets/a0083f90-5a49-49c6-820a-c8f7a3e630af


Security Huds

https://github.com/user-attachments/assets/e1006be6-bf1f-4e69-9db7-bd51d3d3d16a


Medical Huds

https://github.com/user-attachments/assets/6f34b332-7212-4b43-844a-6757dbf3aeda


Cloning

https://github.com/user-attachments/assets/39dcb163-928c-4b26-9a72-86cb92f9ea67

Changelog

:cl: jlsnow301, robbertapir, atosti, lessthnthree, JupiterJaeden, NamelessFairy, Vincent983, JohnFulpWillard, 00-Steven, GoldenAlpharex, Archemagus, XeonMations refactor: Refactored the security, medical and general manifests to TGUI. /:cl:

XeonMations avatar Sep 22 '24 19:09 XeonMations