BeeStation-Hornet
BeeStation-Hornet copied to clipboard
BeeStation
[MDB Ignore] Monkey to species, take 2
About The Pull Request
Title.
closes #8376 closes #9120
Recoup of #10156
Reverts #6694, #8962 as they are now obsolete.
Basically, monkeys are species, with all that entails. We are throwing the shitcode away that needed like 10 different refactors over 3 years to deal with, cause the code is fundamentally garbo.
Humans and Monkeys are already interconnected, no way out of it, so we might as well make the code sane.
Basically, we can make monkeys functionally identical to humans, but we need several explicit drawbacks.
- Absolutely no consoles.
- Probably cant understand most electronic tools
- Some weapon restrictions or two.
- Not roundstart race
Lmk if theres any others that tickle your noggin that you think would make this change make them "OP"
TODO
- [x] Either fix teratomas or just remove them. Terrible duplicated shitcode.
- [x] fix clothing layering offsets (its kinda annoying to work with, pursuing TG's filter system if Racc doesnt respond)
- [x] audit monkey dexterity
- [x] audit
monkeyize()&humanize()
Ports:
- https://github.com/tgstation/tgstation/pull/55614
- https://github.com/tgstation/tgstation/pull/56620
- https://github.com/tgstation/tgstation/pull/62127
- https://github.com/tgstation/tgstation/pull/69453
- https://github.com/tgstation/tgstation/pull/70356
Why It's Good For The Game
No more aheals when changing race
Hunger is persistent when changing between monkey and humans
All stat vars are not reset inbetween transformations
woaw, genetics dont SUCK
Monkey organs dont runtime the fuck out when they try and do species stuff (who put HUMAN organs inside CARBONS!!!?!)
Testing Photographs and Procedure
Screenshots&Videos
Roundstart monkey ---> human
https://github.com/user-attachments/assets/4113c747-5336-4309-8dfa-a202c0b70a8c
Roundstart human ---> monkey
https://github.com/user-attachments/assets/ae7dda91-a268-4305-8da3-dca6ffb8c2af
Monkeys can hold and use two handed weapons, but they do not have the upper core strength to use both arms as a human would.
https://github.com/user-attachments/assets/42dba7c1-38d7-4a85-9f39-d372dc1f5ab9
Changelog
:cl: DrDuckedGoose(species design & appearance) rkz(balancing and mass conversions), qustinnus, coiax, IndieanaJones, itseasytosee add: monkeys are now species add: monkey tails are now handled like actual tail organs, rather than just being a sprite. They apply and are subtyped the exact same way catgirl tails are, minus a wag animation. balance: Monkeys can do a lot more things code: converted mob ventcrawling into flags/traits /:cl:
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Some weapon restrictions or two.
When it comes to weapons, would they be limited to only melee weapons or such? Would it be obvious what kind of weapons they can or can not use?
When it comes to weapons, would they be limited to only melee weapons or such?
Thats not the case now, I dont really plan to implement further restrictions than now. Honestly it will likely be a reduction, atleast in regards to "dexterity".
Would it be obvious what kind of weapons they can or can not use?
In your head, what makes sense to you what a monkey could reasonably use as a weapon? Making consistent use of tools to build a society and passing ones generational knowledge is the defining trait that allowed Humans to grow beyond what Octopi, Dolphins, Crows and Chimpanzees and all other creatures we consider to be "sentient", have now. A gun however? You put the ammo you find on the floor in and press a button, and it hurts something. Easy. Easier even for a monkey with a cybernetic brain amplifier.
Monkeys will be able to handle most weapons, the primary limitation I've discussed with Racc so far is a complete restriction on dual-handed weaponry. A monkey being able to pull a trigger, especially for laser weaponry which historically in Sci-Fi have zero recoil? Sure.
A monkey having the correct frame to actually aim a rifle or shotgun? Fat chance. You ever saw that CGI clip of the monkey with the AK-47? Its like that for him. His finger fits, but his frame really doesn't support the proper holding & aiming of the gun.
https://tenor.com/view/planet-of-the-apes-monkey-gun-shooting-gif-17888605
You talked about melee. It will likely be the same. Most problematic weapons have already balanced themselves. The monkey cannot wield a fireaxe, or spear as the hilt/handle is twice his height. Not possible. I am satisfied somewhat with the same restriction between guns and melee.
I'm considering making bows more accessible for monkeys, like the ashlanders use. That will likely be an expansion however. I want to see how this flies in general first.
Overall, I want TG's fixes brought over by this repath, but want to avoid the pitfalls of monkestations "Simians". I want monkeys on Bee to be, at their base, primitives not unlike ashlanders. They are not to be "Humans but small & can ventcrawl, lmao"
Issues Ive noticed so far:
Racc:
- [ ] Filters can be seen behind walls. Probably just a layering issue?
- [x] Humans turned into monkeys, then turned back into humans retain the monkey height. Probably just need to add an extra proc between monkeyize & humanize, and just add & take from a var on the mind.
var/originalheightor something?
Rkz:
- [x] Monkeys have the monkeyized gene. I need to decid whether to remove it for monkeys or make it turn them into a human. I prefer the first, as it doesnt really make sense for a primitive species not descendant of humans to be able to turn into them. Humans able to turn into a great ape ancestor makes sense, less so for monkeys
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
fat finger. I love when the checks ui moves spontaneously. Such good design
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
fuck it, lets just fold monkey tails into human tails instead of their own snowflake
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This pull request has conflicts, please resolve those before we can evaluate the pull request.