BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

[PORT] Follows up TG's atom_hud system

Open EvilDragonfiend opened this issue 10 months ago • 5 comments

About The Pull Request

Follows up TG's atom_hud system

  • Main PR https://github.com/tgstation/tgstation/pull/65189 https://github.com/tgstation/tgstation/pull/73005 https://github.com/tgstation/tgstation/pull/73267
  • Additional PRs
    • https://github.com/tgstation/tgstation/pull/65604
    • https://github.com/tgstation/tgstation/pull/81338
      • This prolly fixes circuit overlay bugs
    • https://github.com/tgstation/tgstation/pull/71060
    • https://github.com/tgstation/tgstation/pull/67976

IMPORTANT: dependency

  • https://github.com/BeeStation/BeeStation-Hornet/pull/10908

big amount of images being dumped into client/list/images has been an issue causing a lot of maptick. This PR ports their atom_hud that prevents things being injected into a client needlessly when they can't see stuff from another z level

  • Var name changes:
    • show_to(mob) is easier to understand than add_hud_to(mob)
    • add_atom_to_hud() than add_to_hud()
    • remove_atom_from_hud() than remove_from_hud(). it might be correct, but it's confusing grammarly. remove SOMETHING from somewhere is grammarly correct, so TG changed it to remove_atom_from_hud(). I am happy with it too.
    • hide_from() than remove_hud_from()
    • again: show_to(mob) <- add_hud_to(mob) add_atom_to_hud() <- add_to_hud() hide_from() <- remove_hud_from() remove_atom_from_hud() <- remove_from_hud()
  • Single arbitrary var name like M or S for med_hud and sec_hud is a bad arbitrary usecase. We'd think M is an arbitrary var name for mob, not med_hud, and others too.
    • H (as hud) isn't that nice too

Why It's Good For The Game

Greatly good for performance

Testing Photographs and Procedure

Screenshots&Videos

image

image

previously, it's 300 images now it's cull down to 19 images

image

fine all as normal status

Changelog

:cl: LemonInTheDark, MrMelbert, SmArtKar, RandomGamer123, Sealed101 (Port by EvilDragon) code: improved atom_hud system to greatly improve performance for maptick, with bug fix PRs along fix: fixed some circuit overlay issues code: You can see HUD through camera even with the up-to-date HUD system. (by EvilDragonfiend) /:cl:

EvilDragonfiend avatar Apr 17 '24 03:04 EvilDragonfiend

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 18 '24 11:05 github-actions[bot]

This needs more touches. The code is based on Plane Cube, and it isn't compatible well with z-mimics.

EvilDragonfiend avatar Jul 11 '24 06:07 EvilDragonfiend

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 16 '24 12:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 20 '24 06:09 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 28 '24 03:09 github-actions[bot]