[PORT] Removes overlay queuing, saves 6/7 seconds of initialize. Lightly modifies stat tracking macros (+some sprite error fix)

[EvilDragonfiend]

About The Pull Request

• https://github.com/tgstation/tgstation/pull/69696

So we have this overlay queuing system right? It's built with the assumption that the "add to overlay list" operation is real expensive, and is thus useful to queue removals or additions.

It turns out that it just isn't, at least during init. In my testing the operation of queuing took LONGER then the actual overlay add/remove did.

That's ignoring the cost of the subsystem's work.

I've also modified part of the stat tracking macro, since it took a good bit of cpu time, and didn't seem to well, do anything. So far as I can tell it always evaluates to 1

This PR does likely bug fix and corrects a weird behaviour There is some removal of zmimic code but it's fully okay and I checked daedalus overylay subsystem follows this TG version.

Why It's Good For The Game

bug fix

Testing Photographs and Procedure

my character is hiding in a pot

fire alarm respects alert level

cult halo okay

mob overlays okay

Changelog

:cl: code: mildly cleaned up flags_1 defines code: ported a refactor of subsystem overlay from TG. Overlay list is now trustful. /:cl:

[EvilDragonfiend]

correcting all icon states are painful

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[EvilDragonfiend]

Has this been tested with multi-z?

not yet. I will try with echo.

[EvilDragonfiend]

Has this been tested with multi-z?

Looks alright to me.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[EvilDragonfiend]

god wtf echo lint failed can't do this today

[EvilDragonfiend]

okay echo lint seems to be not my fault. it's from other PRs too

[EvilDragonfiend]

fixed now. ready for a review.

[github-actions[bot]]

This pull request has conflicts, please resolve those before we can evaluate the pull request.