BeeStation-Hornet icon indicating copy to clipboard operation
BeeStation-Hornet copied to clipboard

TGUI Ports: Force Event Menu

Open Tsar-Salat opened this issue 1 year ago • 6 comments

Ports:

DM Refactors

  • https://github.com/tgstation/tgstation/pull/68055
  • https://github.com/tgstation/tgstation/pull/68472

UI Upgrades

  • https://github.com/tgstation/tgstation/pull/71750
  • https://github.com/tgstation/tgstation/pull/72690

About The Pull Request

This converts the admin force-event menu into a proper TGUI menu, and sorts all the events by type.

Additionally, we can append a description to each event which lets admins know what events do what, rather than having to codedive to find out.

Furthermore, whilst keeping the changes from #10379, admins can now silence all events notifying the players by unchecking a box.

Why It's Good For The Game

I received positive feedback from admins for this. I decided to port this after a conversation regarding how poorly worded some of the events are.

This should erase all ambiguity.

Testing Photographs and Procedure

Screenshots&Videos

https://github.com/BeeStation/BeeStation-Hornet/assets/62388554/97d6aca1-5fac-443a-aaa9-c88786978d79

Changelog

:cl: rkz, Salex08, Profkanos, tralezab add: TGUI-ifies the force-event menu code: improves midround event canceling code admin: admins can now silence events when forcing them /:cl:

Tsar-Salat avatar Jan 21 '24 16:01 Tsar-Salat

Gonna grab more overhauls

Tsar-Salat avatar Jan 21 '24 16:01 Tsar-Salat

Alright, works fine so far.

Just gotta add categories & desc to all these, then we are set.

image

Tsar-Salat avatar Jan 21 '24 16:01 Tsar-Salat

Another day, another banger

JixS4v avatar Jan 21 '24 17:01 JixS4v

Actualy good TGUI change I love shitting on TGUI being added to evrying just because you can, but this is considerably better and nicer then the menu we have right now

llol111 avatar Jan 27 '24 17:01 llol111

Can you please look through existing UIs with lots of fontawesome for missing icons? I am quite concerned about updating it, because they rename stuff a lot between versions.

itsmeow avatar Mar 19 '24 20:03 itsmeow

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 05 '24 09:04 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 19 '24 06:05 github-actions[bot]

I dont know how to use flex, so I dont really know if I can address maints changes here.

This ones going in the can I guess

Tsar-Salat avatar Jun 19 '24 21:06 Tsar-Salat