GromacsWrapper icon indicating copy to clipboard operation
GromacsWrapper copied to clipboard

JOSS paper

Open orbeckst opened this issue 5 years ago • 5 comments

Short software paper for submission to the Journal of Open Source Software.

The paper will be part of the GromacsWrapper repository; this appears to be the common pattern with other JOSS papers.

Closes Issue #147 (This branch will be merged when the paper is submitted.)

Author contributions

  • read #147 for criteria for inclusion
  • reply to #147 and state that you want to be an author
  • for right now: fork the repo and submit PRs against the paper branch or try to edit the paper.md directly on GitHub.

orbeckst avatar Aug 18 '18 01:08 orbeckst

You can start by updating your author meta data in

Follow the examples in the file.

orbeckst avatar Aug 18 '18 01:08 orbeckst

Codecov Report

Merging #158 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   62.63%   62.63%           
=======================================
  Files          21       21           
  Lines        4135     4135           
  Branches      662      662           
=======================================
  Hits         2590     2590           
  Misses       1359     1359           
  Partials      186      186

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaa1905...03eac1a. Read the comment docs.

codecov[bot] avatar Aug 18 '18 01:08 codecov[bot]

I'm a bit worried about the acceptance criteria of JOSS. Even if super convenient, this library is largely a python binding to Gromacs command line interface, and they are somewhat strict about bindings. What do you think?

And what about I'm expect to write? Automatic cached documentation generated from the original tools? Was nice to found the performance issue using the profiler, someone with internal knowledge could find intuitively, but for foreigners is easy to find the spot only profiling.

pslacerda avatar Aug 19 '18 12:08 pslacerda

I would say it pass the criteria because of lots of working knowledge packed in GromacsWrapper. Just by reading the examples was helpful to improve my Gromacs workflows. For example, I'm doing my first membrane simulation and didn't know that was handy to align the membrane on the XY plane with trj_xyfitted.

pslacerda avatar Aug 19 '18 12:08 pslacerda

Probably its my fault but I was not able to push my meta data to the PR. Are there any things I have to consider?

PicoCentauri avatar Sep 07 '18 09:09 PicoCentauri