nyaa icon indicating copy to clipboard operation
nyaa copied to clipboard

Issue found in the following: v/V/Ctrl-Space ⇒ Enter visual add/remove/toggle mode

Open EienNoRyu opened this issue 8 months ago • 1 comments

There are minor errors in the highlighted mode. Here is how they can be reproduced:

Error 1: Issue with Visual Add Mode

Step 1: Enter Visual Add mode Step 2: Try to add a torrent with up or down arrow keys

Issue observed:

No torrent is added for batch download

Error 2: Issue with Visual Toggle Mode

Step 1: Enter Visual Toggle mode Step 2: Select multiple torrents (recommended 12 torrents) with up or down arrow keys Step 3: After batch selection of torrents try to remove all of them with up or down arrow keys

Issue observed:

All torrents can be removed excluding the first torrent that was added initially

NOTE: This initial torrent is removed (along with the batch download pane on the right) when the Visual Toggle Mode hotkey is pressed twice, however, at the same time, when the Visual Toggle Mode is started again (on the consecutive third keypress after the initial first two keypresses) this initial torrent can no longer be seen added in the batch download list

EienNoRyu avatar May 09 '25 06:05 EienNoRyu

That's strange, I'm not able to reproduce issue 1 on main @ 8026e52, but do notice it on released version v0.9.1:

Image

So v0.9.2 should resolve this when that comes out. Not too sure why that functionality is missing.

For issue 2, I believe this is intentional. When entering visual toggle, the starting item will be toggled once and will retain that new state even if you move away and then back towards. This prevents weird situations like this:

Image

A workaround to re-toggle the starting item would be to press Space while selected on the item before exiting visual toggle mode:

Image

Beastwick18 avatar May 12 '25 03:05 Beastwick18

Thanks for your reply and clarifying the stated issues, and sorry for the late reply on my end.

I will be checking the latest release now and will report if I see any errors there.

EienNoRyu avatar Jun 26 '25 03:06 EienNoRyu