VSCode-Angular-TypeScript-Snippets icon indicating copy to clipboard operation
VSCode-Angular-TypeScript-Snippets copied to clipboard

Add CSS Grid Layout Standard snippets

Open sociallyadequategeek opened this issue 7 years ago • 6 comments

BeastCode, Still missing ng-cong? me too!

Now that css grid layout has been adopted by Mozilla and Chrome, would be nice to have some snips.

-MB

sociallyadequategeek avatar Apr 25 '17 14:04 sociallyadequategeek

@BeastCode these type of snippets feel add-on. Perhaps they are a separate package, or use a different prefix?

I guess the bottom line is what does the OP want? Examples? Css grid is dynamic and creating a useful one snip fits all is going to be quite hard.

My suggestion is, while we are refactoring the snippets for Angular 5, we place examples (if that's what the OP intended) in a new prefix, 'example--'. Given this syntax, the OP would find his grid example with 'example-css-grid-layout'

Thoughts?

cgatian avatar Sep 14 '17 08:09 cgatian

Downside to this is you don't have example snippets directly accessible from the real snips. ( Like for ng-pipe, ng-pipe-example). But, I think it actually might clean up the intellisense and provide a nice separation. Users typically know they are looking for the example when they need it. It's not something they decide when navigating the snippet intellisense.

Following this idea through, the pipe example snip would be renamed to:

example-ng-pipe

cgatian avatar Sep 14 '17 09:09 cgatian

How should we group examples? ng-example-
m-example-
ng-example-pipe or example-ng example-m example-ng-pipe

BeastCode avatar Sep 17 '17 19:09 BeastCode

Doing mat- feels like a natural namespace.

So Im taking myself back, and I think we should do mat-example-<type>. But at the same time maybe you had it right the whole time!

mat-pipe-example... Gosh its pretty explicit... Im coming around to your original syntax.

cgatian avatar Sep 17 '17 22:09 cgatian

No I like what you did there. I think doing example-ng-pipe is wrong.

cgatian avatar Sep 17 '17 22:09 cgatian

I went trough the same thoughts when I created the first example snippet. But I do see a point grouping all angular examples ng-example- but at this point there's not many examples///

BeastCode avatar Sep 17 '17 23:09 BeastCode