ForgeNetworkingRemastered icon indicating copy to clipboard operation
ForgeNetworkingRemastered copied to clipboard

Master server not disconnecting properly

Open BrentFarris opened this issue 8 years ago • 7 comments

Version Number and Operating System(s):

Latest Master branch

Expected behavior:

When you play in unity then stop playing the server should be removed from the master server

Actual behavior:

When you play and then stop playing then the server is not removed from the master server

Steps to reproduce:

Setup master server Turn on logging in the master server Play in editor as server to register itself on master server Stop playing in editor and observe that the server does not get removed

BrentFarris avatar Aug 18 '17 17:08 BrentFarris

That is not what i said tho, i said that while i have a server in build running.. ok

  1. I build, run as host
  2. can see server in master server
  3. now press play in editor
  4. press stop
  5. server now dissapears from master, as if i closed the host, but the host is still running!

pointcache avatar Aug 18 '17 17:08 pointcache

So you were running 2 servers on the same machine then @pointcache?

BrentFarris avatar Aug 18 '17 18:08 BrentFarris

No, the build is runing the server, because i hit Host on it, i didnt hit host in editor, i literally did nothing, just play/stop

pointcache avatar Aug 18 '17 18:08 pointcache

Is this reproducible with 2 builds, one where you host and the other where you start it and then close it after seeing the menu scene?

BrentFarris avatar Aug 18 '17 18:08 BrentFarris

I mistook the start/play as related to disconnect, testing shows that disconnect is just time related it seems. Like it just falls off after some time

pointcache avatar Aug 18 '17 18:08 pointcache

That was an issue that we had in the previous code, however this PR should have fixed that: https://github.com/BeardedManStudios/ForgeNetworkingRemastered/commit/a9eea341cb3a97fe2f694b2bf41112efc83477bb

So I'll look into it again.

BrentFarris avatar Aug 18 '17 18:08 BrentFarris

The master server doesn't work for me at all. No server is being registered.

Memorix101 avatar Jul 16 '18 15:07 Memorix101