ForgeNetworkingRemastered icon indicating copy to clipboard operation
ForgeNetworkingRemastered copied to clipboard

Thread safety and stop messages returning to pool too early

Open zaddo67 opened this issue 3 years ago • 0 comments

  • Messages added back to pool while still active in message bus stored messages and repeater lists.
  • Make MessagePoolMulti thread safe as it is called from alloy networking thread and main thread
  • Make BMSBytePool thread safe
  • Two of the SendReliableMessage methods in ForgeNetworkMediator were not sending reliably
  • ForgeUDPSocketServerFacade ChallengeSuccess assumed challenged players still exists in list. Changed to check entry exists. (Might be an issue unique to my project, ok to ignore unless you have same issue)
  • Helper method in ForgeMessageCodes to instantiate message from message type (Can be ignored)
  • Helper Method in IPlayerRepository to check if player signature exists (Can be ignored)

Please note that these changes have not been tested outside of my project. So use appropriate caution if you grab them.

zaddo67 avatar May 25 '21 09:05 zaddo67