Combining an HC and non-HC theme doesn't work with "Toggle Light / Dark Theme"?

[chambliss]

Hi,

I opened an issue with VS Code about this, thinking it was a general editor issue, but it turned out to be specific to my Bearded themes. Please see here for the full original issue description and a video illustrating the issue.

After more testing, this combination (both non-HC themes) allows Toggle to work correctly:

{
  "workbench.preferredLightColorTheme": "Bearded Theme Coffee Cream",
  "workbench.preferredDarkColorTheme": "Bearded Theme Arc Blueberry",
}

This one (HC light theme, normal dark theme) doesn't work correctly, and instead causes VS Code to switch to the default HC light theme (theirs), and then to the default HC dark theme, and goes back and forth between those two.

{
  "workbench.preferredLightColorTheme": "Bearded Theme Milkshake Mango",
  "workbench.preferredDarkColorTheme": "Bearded Theme Arc Blueberry",
}

The end result is the minor inconvenience of switching back to using "Preferences: Color Theme" and typing in which theme to use, rather than using the shortcut I had bound to toggling color theme. Not a huge deal but a slight bummer :)

Based on the response I got on the other issue, I believe it's related to using a high-contrast color theme for my light theme and a normal (dark) color theme for my dark theme. I don't fully understand how theming works, but it might be that combining a HC light theme and a non-HC dark theme is just unsupported for this command. If so, feel free to let me know and close this.

P.S. Thanks for making Bearded Themes! I remember Bearded Themes being among the first to ever support semantic highlighting when that was new. I've been using them for many years now. I've made some customizations over time, but they are all incredibly thoughtful and well-designed out of the box.