TeamTalk5 icon indicating copy to clipboard operation
TeamTalk5 copied to clipboard

Fix UTF-8 Encoding Errors on TeamTalkClassic

Open hwangsihu opened this issue 4 months ago • 7 comments

hwangsihu avatar Oct 22 '25 06:10 hwangsihu

@hwangsihu the tt5srv.log file doesn't support utf 8 as well. if system locall is set to english, and in the teamtalk server, people send persion or arabik messages to each other for example, it replaces by question marks. Please fix this as wel. I've reported this before, but anyone didn't pay any attention.

amirmahdifard avatar Oct 24 '25 20:10 amirmahdifard

This is used by CTeamTalkDlg::OnCopyData

@bear101, do you have any good ideas on how to fix this? The build seems to work fine in GitHub Actions, but I'm having trouble on my computer. Could it be because my computer's language is Korean?

hwangsihu avatar Oct 26 '25 07:10 hwangsihu

@hwangsihu In Library/TeamTalkLib/teamtalk/Log.h try adding UnicodeToUtf8(TXT).c_str() on Windows.

#include "myace/MyACE.h"
#if defined(UNICODE)
#define TT_LOG(TXT)  ACE_DEBUG((LM_INFO, ACE_TEXT("%D %s\n"), UnicodeToUtf8(TXT).c_str()))
#else
#define TT_LOG(TXT)  ACE_DEBUG((LM_INFO, ACE_TEXT("%D %s\n"), TXT))
#endif

bear101 avatar Oct 27 '25 20:10 bear101

@hwangsihu i'm sorry, did you see my comment? can the utf issue be fixed in windows server log file as well, So we don't have to change system local in auder to support persian and arabik langs when people send messages like this?

amirmahdifard avatar Oct 28 '25 13:10 amirmahdifard

@hwangsihu i'm sorry, did you see my comment? can the utf issue be fixed in windows server log file as well, So we don't have to change system local in auder to support persian and arabik langs when people send messages like this?

Please, stop bothering people. Did you even see @bear101's comment? I'll proceed exactly as that comment says.

hwangsihu avatar Oct 28 '25 13:10 hwangsihu

Hmm... it doesn't work. Instead, I've encountered an absurd situation where English characters are broken. For now, I think it would be better to create a separate PR to address this issue later.

hwangsihu avatar Oct 29 '25 13:10 hwangsihu

@bear101, NVDA wasn't reading anything in notepad, so I rewrote the symbol and it seems to work fine. Can you see it again?

hwangsihu avatar Nov 02 '25 01:11 hwangsihu