TeamTalk5 icon indicating copy to clipboard operation
TeamTalk5 copied to clipboard

Receive combined text messages on Android

Open bear101 opened this issue 2 years ago • 4 comments

@poretsky In TeamTalk v5.9 I've added 'bMore' member variable to TextMessage-class. When 'bMore' is set then the current message type (nMsgType) is part of a combined message. The combined TextMessage ends when 'bMore' is cleared (false).

Can you find a way for TextMessageAdapter to support this type of messages? Basically TextMessageAdapter should not update until all TextMessages with 'bMore' has been received.

bear101 avatar Mar 30 '22 05:03 bear101

Here's how TextMessages are split: https://github.com/BearWare/TeamTalk5/blob/android-recv-longmsg/Client/TeamTalkAndroid/src/main/java/dk/bearware/data/MyTextMessage.java#L62

Here's how TextMessages are combined: https://github.com/BearWare/TeamTalk5/blob/android-recv-longmsg/Client/TeamTalkAndroid/src/main/java/dk/bearware/data/MyTextMessage.java#L99

bear101 avatar Mar 30 '22 05:03 bear101

Here's an example of sending a TextMessage: https://github.com/BearWare/TeamTalk5/blob/android-recv-longmsg/Client/TeamTalkAndroid/src/main/java/dk/bearware/gui/MainActivity.java#L846

bear101 avatar Mar 30 '22 05:03 bear101

@beqabeqa473 Maybe you could also have a look at this

bear101 avatar Mar 30 '22 05:03 bear101

This PR so far only does the merge part of TextMessage. TextMessageAdapter should not show the message until bMore=false.

Maybe it's enough to change TextMessageActivity.onCmdUserTextMessage() to not update if bMore=true.

bear101 avatar May 14 '23 07:05 bear101