fix : dot removing when last digit is erased
Describe your changes
closes #522
I stored the string version of my value to keep the dot on display and make it priority on value formatted
Screenshots
(can't see my cursor because of the recorder, but Im just clicking away, it formatting itself)
Screencast from 2024-12-26 14-17-40.webm
Checklist
- [x] I performed a self review of my code
- [x] I ensured that everything is written in English
- [x] I tested the feature or fix on my local environment
- [x] I ran the
pnpm storybookcommand and everything is working - [x] If applicable, I created a PR or an issue on the documentation repository
- [x] If applicable, Iβm sure that my feature or my component is mobile first and available correctly on desktop
Summary by CodeRabbit
-
New Features
- Enhanced input handling in the
InputNumbercomponent to maintain a separate representation of raw input values.
- Enhanced input handling in the
-
Bug Fixes
- Improved the control flow for managing numeric input changes, particularly with keyboard interactions.
@DylanFlandrin is attempting to deploy a commit to the Team Bearstudio Team on Vercel.
A member of the Team first needs to authorize it.
Walkthrough
The changes modify the InputNumber component in the src/components/InputNumber/index.tsx file by introducing a new state variable rawInput. This variable is designed to manage the raw input value from the NumericFormat component, allowing more flexible handling of numeric input. The modification aims to improve the input behavior, particularly focusing on how decimal separators and numeric formatting are managed during user interactions.
Changes
| File | Change Summary |
|---|---|
src/components/InputNumber/index.tsx |
- Added new state variable rawInput to track raw input value- Modified onValueChange handler to update rawInput- Updated Input component's value prop to use rawInput |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Preserve decimal separator when partially deleting number [#522] | β | Requires further verification of actual input behavior |
The changes appear to be a step towards addressing the issue, but a comprehensive test of the exact scenario described would be needed to confirm full resolution. The introduction of rawInput suggests an attempt to improve input handling, but the specific behavior with decimal separators needs to be validated through thorough testing.
Note: No sequence diagram is generated as the changes are primarily focused on state management and do not introduce a significant new control flow.
π Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
π₯ Commits
Reviewing files that changed from the base of the PR and between 00886f832af47b43c37530e9a636abafa8cc00e7 and 8f89466c6b4071208fee6dbba84227c26a91f18f.
π Files selected for processing (1)
-
src/components/InputNumber/index.tsx(4 hunks)
π§ Files skipped from review as they are similar to previous changes (1)
- src/components/InputNumber/index.tsx
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
πͺ§ Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai generate docstringsto generate docstrings for this PR. (Beta) -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code