start-ui-web icon indicating copy to clipboard operation
start-ui-web copied to clipboard

fix: replacing usecolormodevalue to _dark

Open gracebir opened this issue 2 years ago β€’ 8 comments

Describe your changes

replacing useColorModeValue with _dark

Screenshots

Screenshot from 2023-09-04 12-08-28

gracebir avatar Sep 03 '23 19:09 gracebir

@gracebir is attempting to deploy a commit to the Team Bearstudio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 03 '23 19:09 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
start-ui βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 4, 2023 10:52am

vercel[bot] avatar Sep 04 '23 10:09 vercel[bot]

Hi @gracebir! Thanks a lot for this PR! But unfortunately it's seems broken :/ image

You can check here the issue in dark mode https://start-ui-git-fork-gracebir-revert-usecolormodevalue-bearstudio.vercel.app/storybook/index.html?path=/docs/components-select--docs image

ivan-dalmet avatar Sep 04 '23 11:09 ivan-dalmet

And by reading the code change, this will not work unfortunately. The object that you updated needs to output real css not Chakra values ;)

ivan-dalmet avatar Sep 04 '23 11:09 ivan-dalmet

And by reading the code change, this will not work unfortunately. The object that you updated needs to output real css not Chakra values ;)

@ivan-dalmet , could please you articulate, what do mean you by output real css?

gracebir avatar Sep 04 '23 13:09 gracebir

And by reading the code change, this will not work unfortunately. The object that you updated needs to output real css not Chakra values ;)

@ivan-dalmet , could please you articulate, what do mean you by output real css?

The library we are using for the Select component is react-select and to customize the react-select styles, we can't use Chakra UI "selectors" like _hover or _dark. I think we need to provide real CSS in JS for this component.

Also, we can't use Chakra variables as is (like brand.600) because it has no value in CSS, we need to convert it before (using Chakra's helper) so brand.600 become a CSS value like #ad032c for example.

yoannfleurydev avatar Sep 04 '23 13:09 yoannfleurydev

And by reading the code change, this will not work unfortunately. The object that you updated needs to output real css not Chakra values ;)

@ivan-dalmet , could please you articulate, what do mean you by output real css?

The library we are using for the Select component is react-select and to customize the react-select styles, we can't use Chakra UI "selectors" like _hover or _dark. I think we need to provide real CSS in JS for this component.

Also, we can't use Chakra variables as is (like brand.600) because it has no value in CSS, we need to convert it before (using Chakra's helper) so brand.600 become a CSS value like #ad032c for example.

sure @yoannfleurydev

gracebir avatar Sep 04 '23 14:09 gracebir

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 05 '23 12:09 sonarqubecloud[bot]