start-ui-web icon indicating copy to clipboard operation
start-ui-web copied to clipboard

feat(#126): add tool to generate stories

Open yoannfleurydev opened this issue 2 years ago β€’ 3 comments

This PR is a start for the #126 discussion.

https://user-images.githubusercontent.com/3920615/189230973-7b7fcfdb-f402-4052-ae61-e29b6612581f.mp4

yoannfleurydev avatar Sep 08 '22 21:09 yoannfleurydev

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
start-ui βœ… Ready (Inspect) Visit Preview Sep 13, 2022 at 0:27AM (UTC)

vercel[bot] avatar Sep 08 '22 21:09 vercel[bot]

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 13 '22 12:09 sonarqubecloud[bot]

if i select a component without a index.tsx filename

$ plop story
? Component name for story src/app/auth/PageLogin.tsx
βœ”  ++ /src/app/auth/docs.stories.tsx
Done in 26.97s.

the result is not correct

import React from 'react';
import { ComponentMeta } from '@storybook/react';

import { Auth } from '@/app/auth';

export default {
  title: 'App/Auth',
} as ComponentMeta<typeof Auth>;

export const Default = () => (
  <Auth />
)

Jessy-BAER avatar Sep 22 '22 10:09 Jessy-BAER

Just a thought: I have to be honest, I'm not a huge fan anymore of that PR.

  1. We already have a lot to maintain, I'm not sure adding new feature like that is that useful to everyone.
  2. This could be done through Start UI documentation by documenting how to add useful snippets in IDEs
  3. Generators is what we want to avoid providing Start UI
  4. Mixing JS (plopfile config) with TS (all the rest) is not that great even if they are not related.

yoannfleurydev avatar Apr 24 '23 21:04 yoannfleurydev

Closed for all the reasons above

DecampsRenan avatar Jun 09 '23 12:06 DecampsRenan