beanie
beanie copied to clipboard
BeanieODM
Type hint overall improving
Fix correct return type for query update operation, fix type hint for sort, correct return type for document update and removed awaitable making it not able to be used in asyncio task
for expression field it can allow to define the type like inc, only taking number for inc operation, taking any for set ? for current_time maybe taking only datetime or any affiliate things ?
for expression field it can allow to define the type like inc, only taking number for inc operation, taking any for set ? for current_time maybe taking only datetime or any affiliate things ?
@roman-right which i can add if you think its ok (i think it would be great to take that)
other than that my pull request is normally ok (i tested it with pytest)?
Hi @CAPITAINMARVEL , How did you test these types? Did you use type checker?
Hi @CAPITAINMARVEL , How did you test this types? Did you use type checker?
Thanks for the reply i will fix it
This PR is stale because it has been open 45 days with no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR was closed because it has been stalled for 14 days with no activity.
@CAPITAINMARVEL, please resolve the conflicts.
I just did but pre commit didn’t pass ?
Ah mypy error i see
Ill fix the rest tomorrow on computer didn’t know it would trigger the test again