beanie icon indicating copy to clipboard operation
beanie copied to clipboard

Update documents.py

Open CAPITAINMARVEL opened this issue 1 year ago • 6 comments

fix uniondoc DocType

CAPITAINMARVEL avatar Dec 18 '23 19:12 CAPITAINMARVEL

Ah shit

CAPITAINMARVEL avatar Dec 25 '23 08:12 CAPITAINMARVEL

@roman-right i think im gonna do it with only type hint improving for the union doc issue its within the union_doc folder i was thinking inheriting from document one but there some function not available in union doc so its more complexe than i thought

CAPITAINMARVEL avatar Jan 11 '24 09:01 CAPITAINMARVEL

Bad timing i had to go and shouldnt have push now i think its ok

CAPITAINMARVEL avatar Jan 11 '24 19:01 CAPITAINMARVEL

Should be good now i can start again if you want cause with all commits its messy @roman-right

CAPITAINMARVEL avatar Jan 16 '24 12:01 CAPITAINMARVEL

Hey @CAPITAINMARVEL , Could you please take a look at the tests?

Regarding the amount of commits - everything is ok. I use squash merging strategy - it will be 1 commit in the main branch in the end anyway :)

roman-right avatar Jan 16 '24 15:01 roman-right

Hey @CAPITAINMARVEL , Could you please take a look at the tests?

Regarding the amount of commits - everything is ok. I use squash merging strategy - it will be 1 commit in the main branch in the end anyway :)

hopefully this time its good

CAPITAINMARVEL avatar Jan 16 '24 20:01 CAPITAINMARVEL

fixed ? @roman-right

CAPITAINMARVEL avatar Jan 22 '24 09:01 CAPITAINMARVEL

Should be good error now @roman-right

CAPITAINMARVEL avatar Jan 23 '24 07:01 CAPITAINMARVEL

yeah i cant remove that error its like an hacky way but Union Doc find work same as document find so thats why i change doc type with Union [uniondoc and document]

CAPITAINMARVEL avatar Jan 24 '24 10:01 CAPITAINMARVEL

Hi @CAPITAINMARVEL , I'll fix the merge conflict and take a look at the error by the end of today

roman-right avatar Jan 24 '24 17:01 roman-right

Hm, it looks like part of the problem has alternative solution there already. Could you please take a look? @CAPITAINMARVEL

roman-right avatar Jan 24 '24 17:01 roman-right