beanie
beanie copied to clipboard
Update documents.py
fix uniondoc DocType
Ah shit
@roman-right i think im gonna do it with only type hint improving for the union doc issue its within the union_doc folder i was thinking inheriting from document one but there some function not available in union doc so its more complexe than i thought
Bad timing i had to go and shouldnt have push now i think its ok
Should be good now i can start again if you want cause with all commits its messy @roman-right
Hey @CAPITAINMARVEL , Could you please take a look at the tests?
Regarding the amount of commits - everything is ok. I use squash merging strategy - it will be 1 commit in the main branch in the end anyway :)
Hey @CAPITAINMARVEL , Could you please take a look at the tests?
Regarding the amount of commits - everything is ok. I use squash merging strategy - it will be 1 commit in the main branch in the end anyway :)
hopefully this time its good
fixed ? @roman-right
Should be good error now @roman-right
yeah i cant remove that error its like an hacky way but Union Doc find work same as document find so thats why i change doc type with Union [uniondoc and document]
Hi @CAPITAINMARVEL , I'll fix the merge conflict and take a look at the error by the end of today
Hm, it looks like part of the problem has alternative solution there already. Could you please take a look? @CAPITAINMARVEL