beam-ui icon indicating copy to clipboard operation
beam-ui copied to clipboard

Refactor the folder ui/viewmodel and ELSeedValidator. Replace RegExpValidator (deprecated) with RegularExpressionValidator.

Open kogawulf opened this issue 1 year ago • 1 comments

Refactor ui/viewmodel

Determine which files and classes are considered "helper" files/objects and move them into appropriate subfolders. This requires feedback from other contributors to decide best layout.

Suggested (or to be considered) files -- along with their .h counterparts of course

Refactor class ELSeedValidator

  • ELSeedValidator inherits from QValidator, and then seems to implement a regular expression validation manually in its validate() method. The validate method contains the allowed regular expression to be checked against.
  • Shouldn't this operate in the same way as every other validate method? That is, the regular expression is defined in the QML file, in this case SeedInput.qml.
  • So, shouldn't ELSeedValidator simply inherit from RegularExpressionValidator so it can call the parent validate() method to check the regular expression, and then do the extra code in its validate() method?

Refactor RegExpValidator references

RegExpValidator is apparently deprecated and it is recommended to use RegularExpressionValidator

kogawulf avatar May 20 '24 14:05 kogawulf

@anatolse

Maxnflaxl avatar May 21 '24 10:05 Maxnflaxl