All roof types should allow holes

[justinormont]

Only skillion and flat roof types allow for buildings with holes. Other roof types cover the hole.

Working

skillion:

flat:

Not working

pyramidal:

onion:

dome:

[Beakerboy]

Do you have an example of a building with a holey onion roof?

I love that someone is looking at the code, using it, and contributing! Thanks!

[justinormont]

Do you have an example of a building with a holey onion roof?

All holey onion roofs -- https://overpass-turbo.eu/s/1NRS

Example of a holey onion roof -- https://openstreetmap.org/edit?relation=10084055

Open Street Maps:

OsmBuilding render: (link)

F4 render:

I love that someone is looking at the code, using it, and contributing! Thanks!

Quite welcome. Thanks for continuing to build and maintain this project.

[Beakerboy]

It seems this query probably does a better job at identifying mislabeled buildings. I can’t see an onion room feature in the aerial imagery or streetview. My vote would be that the renderer place an onion in the largest roof area that does not cover any hole, or just fill the outline with one large onion. I’m more concerned that the program has chosen to create 5 separate onions than by the lack of a hole.