OSMBuilding icon indicating copy to clipboard operation
OSMBuilding copied to clipboard

Cardinal Directions for Roofs and Misc Roof Fixes

Open justinormont opened this issue 1 year ago • 2 comments

Additions:

  • Add cardinal directions (N, S, WNW, ...) processing to roofs

Fixes:

  • Remove extraneous 'round' from list
  • Fix false warning for roof.direction='0' (north-facing) for skillion roofs

Closes https://github.com/Beakerboy/OSMBuilding/issues/60

justinormont avatar Jul 07 '24 21:07 justinormont

Could you add a test for the new cardinal direction code? And one that demonstrates that a building with a north roof does not produce an entry in the error log, but one with a missing direction does?

Beakerboy avatar Jul 08 '24 14:07 Beakerboy

I submitted a pull request to your branch. Please review it and let me know what you think. I refactored your function to make is shorter and created a unit test for it. It still needs a test for the message in the error log.

Beakerboy avatar Jul 18 '24 11:07 Beakerboy