Be

I just found [embassy_futures::block_on](https://docs.rs/embassy-futures/latest/embassy_futures/fn.block_on.html), however, I don't think it's a good idea to use it to impl Drop for async Files/Volumes. We can't know if a user would want that...

[tokio::fs::File](https://docs.rs/tokio/latest/tokio/fs/struct.File.html): > A file will not be closed immediately when it goes out of scope if there are any IO operations that have not yet completed. To ensure that a...

> Suggestion: impl Drop for async File/Volume using embassy_futures::block_on, but put that behind an async_drop Cargo feature that is enabled by default. This will Just Work by default, and any...

Some blogs about async drop: https://without.boats/blog/asynchronous-clean-up/ https://sabrinajewson.org/blog/async-drop https://smallcultfollowing.com/babysteps/blog/2023/03/16/must-move-types/ TL;DR: It's complicated and Rust is a long way from async drop being implemented. Probably not for some more years. Blocking in...

Directory::drop doesn't make any async calls, so there's nothing to do there. The existing implementation is already enough.

Thanks for testing and digging into this @avsaase and @ValouBambou! I documented the requirement for enabling a `generic-queue-x` feature on the embassy-time crate when dropping a File or Volume from...

That's a pretty bad failure mode and makes me wonder if we should have the option to Drop File and Volume. We could panic in those Drop impls with a...

> I can't seem to trigger an external branch workflow in our Actions. That may be because the action was set to trigger only on pushing a tag. For testing...

FWIW I tested building with the gn option `use_sysroot=true` with host GNU and LLVM toolchains because I thought it might make more sense to add a `--use-sysroot` command line option...

Interesting, I have not seen that error before :thinking: What distro are you using? I notice the error mentions /usr/bin/ld, which is probably the GNU linker. Rust [no longer uses...