mfakto icon indicating copy to clipboard operation
mfakto copied to clipboard

JSON results / barrett15 false positive fix / version bump

Open brubsby opened this issue 1 year ago • 3 comments

I've been working on making changes to mfakto that I've made to mfaktc to support json results, as part of an effort to integrate mfakt* programs with primenet.py, as part of this I've also fixed a false negative issue with cards using double precision math for divisions, and am hoping to release prerelease builds to others for testing.

It seems like this repo hasn't kept up putting out releases, but that would be helpful to me. I can release builds from my fork, but I think bdot is not active anymore, so I'm not sure to what extent I can contribute to this repo.

Also release 0.17pre7 on this repo seems very bizarre, the actual version number of the packaged software is like 0.15pre7 (or something). Could that release be renamed to 0.15pre7? It's caused some confusion in the mfakto thread on mersenneforum

brubsby avatar Aug 20 '24 21:08 brubsby

The message "This branch has no conflicts with the base branch" is misleading. There are conflicts, but GitHub fails to see them. One of the commits is a merge commit. It should normally be avoided in pull requests. Non-linear history is harder to bisect in case of problems.

I've attempted to rebase the merge out of existence, hopefully this hasn't caused any other problems, let me know if there's anything else I can do.

brubsby avatar Aug 21 '24 17:08 brubsby

It there any test case that would fail without the barrett15 fix (with double precision) and pass with the fix? It should be added to catch similar issues in the future.

proski avatar Sep 03 '24 06:09 proski

It there any test case that would fail without the barrett15 fix (with double precision) and pass with the fix? It should be added to catch similar issues in the future.

IIRC, there were many test cases in -st and -st2, though maybe some of them could be added to the quickstart tests.

brubsby avatar Sep 04 '24 18:09 brubsby

Running on windows, 6700XT - fails the sanity selfcheck for me.

Compiling kernels.
  GPUSievePrimes (adjusted) 81206
  GPUsieve minimum exponent 1037054
Started a simple self-test ...
ERROR: self-test failed for M51332417 (cl_barrett15_69_gs)
  no factor found
ERROR: self-test failed for M50896831 (cl_barrett15_71_gs)
  no factor found
ERROR: self-test failed for M50979079 (cl_barrett15_73_gs)
  no factor found
ERROR: self-test failed for M51232133 (cl_barrett15_73_gs)
  no factor found
ERROR: self-test failed for M50830523 (cl_barrett15_73_gs)
  no factor found
ERROR: self-test failed for M50752613 (cl_barrett15_73_gs)
  no factor found
ERROR: self-test failed for M51507913 (cl_barrett15_73_gs)
  no factor found
ERROR: self-test failed for M51916901 (cl_barrett15_74_gs)
  no factor found
ERROR: self-test failed for M50805581 (cl_barrett15_82_gs)
  no factor found
ERROR: self-test failed for M51157429 (cl_barrett15_82_gs)
  no factor found
ERROR: self-test failed for M51406151 (cl_barrett15_82_gs)
  no factor found
ERROR: self-test failed for M51478381 (cl_barrett15_82_gs)
  no factor found
ERROR: self-test failed for M51350527 (cl_barrett15_82_gs)
  no factor found
ERROR: self-test failed for M53061139 (cl_barrett15_82_gs)
  no factor found
ERROR: self-test failed for M48629519 (cl_barrett15_83_gs)
  no factor found
ERROR: self-test failed for M55069117 (cl_barrett15_69_gs)
  no factor found
ERROR: self-test failed for M45448679 (cl_barrett15_83_gs)
  no factor found

Self-test statistics
  number of tests           30
  successful tests          13
  no factor found           17

self-test FAILED!


k3ack3r avatar Sep 19 '24 23:09 k3ack3r

@k3ack3r Does this happen with the latest "stable" code?

ixfd64 avatar Sep 20 '24 22:09 ixfd64