nas-without-training icon indicating copy to clipboard operation
nas-without-training copied to clipboard

Random indices in search.py

Open YuhuaBillChen opened this issue 4 years ago • 1 comments

Hi @jack-willturner , I came across the code in search.py and noticed that the sample architecture indices are generated from np.random.randint, which will result in duplicated numbers.

It should not be a big issue when the sampling size is relatively small. However, I think it is better to replace it with np.random.choice to avoid evaluating the same network twice.

Thanks, Bill

YuhuaBillChen avatar Jun 30 '20 18:06 YuhuaBillChen

Good spot, thank you! I'll re-run the experiments with np.random.choice instead and update the code/results soon.

jack-willturner avatar Jul 03 '20 12:07 jack-willturner