kamon-prometheus icon indicating copy to clipboard operation
kamon-prometheus copied to clipboard

Published 20 hours ago • verified publisher icon Bayer-Group

Histogram buckets should have _bucket suffix in text format

Open brian-brazil opened this issue 8 years ago • 3 comments

Hi,

Per https://prometheus.io/docs/instrumenting/exposition_formats/#text-format-details histogram buckets should have the _bucket suffix. This should be fixed at https://github.com/MonsantoCo/kamon-prometheus/blob/420b2a8ba8b8307ad944f2b9eb77306c6ca11bb8/library/src/main/scala/com/monsanto/arch/kamon/prometheus/metric/TextFormat.scala#L22

brian-brazil avatar Feb 07 '17 14:02 brian-brazil

why didn't you do a PR? you basically found the error, and the solution? it would take you 5 more minutes...

mirkof avatar Mar 23 '17 09:03 mirkof

I was just reading through the code to see how it worked and noted this bug, I don't use this library.

Generally I'd recommend switching this to using the standard java client, and only offering a collector in this repository, rather than duplicating effort.

brian-brazil avatar Mar 23 '17 09:03 brian-brazil

I've pushed pull request #19 which should address this issue. please check

milenkovicm avatar Apr 24 '17 14:04 milenkovicm