Results 40 comments of Michael Baumgartner

Why does the BitBucket to LocalVC Migration uses two extra keys for `@Value`? Both does not seem to be necessary for me: 1. [migration.local-vcs-repo-path](https://github.com/ls1intum/Artemis/blob/7d299a4aae82b1db9f44b1c86965f89c14ad898c/src/main/java/de/tum/in/www1/artemis/config/migration/entries/BitbucketLocalVCMigrationService.java#L22) could be replaced with `artemis.version-control.local-vcs-repo-path`, which...

Thanks @reschandreas, with this background information I agree with @b-fein. I moved to the existing values for the migration here (see 55836b787974b38a1b7cc354f96cbf0963bfb91d).

The log message [here](https://github.com/ls1intum/Artemis/blob/7d299a4aae82b1db9f44b1c86965f89c14ad898c/src/main/java/de/tum/in/www1/artemis/config/migration/entries/MigrationEntry20240103_143700.java#L338) claims that the URL will not be changed in the database, because the migration failed. In contrast to this the lines 344 and 345 are also...

Okay, I fixed that bug (13e0764). However, this bug would have led to an `null` URL in the database (if that is possible). An old URL is still possible if...

Another GitLab specific thing is in the Artemis Database. If tokens are used for the authentication of the users against GitLab, Artemis stores these tokens in the column `vcs_access_token` of...

To make sure that the old tokens do not cause any trouble or became unnecessary data, the migration now removes the token data (da6b3b3). FYI: @SimonEntholzer

Actual status: 1. There is a migration available with Pull Request #8972 2. The documentation now contains a [Jenkins-LocalVC section](https://docs.artemis.cit.tum.de/dev/setup/jenkins-localvc.html) and [Jenkins-GitLab section](https://docs.artemis.cit.tum.de/dev/setup/jenkins-gitlab.html) contains a warning that it will get...

The HTML escaped characters, which are in the license texts, are not correctly handled in every situation by Markdown renderers. For example`"` is not rendered as a `"`. Even if...

I also have `window-rs` targets in my dependency and I have no problem. It seems that the crates have now a license in there Cargo.toml, for example here: https://github.com/microsoft/windows-rs/blob/a87e98eb5f6a6d55eea24d44a60cfe71e1462071/crates/targets/x86_64_gnu/Cargo.toml#L6

I also come across this problem, but currently the need for `~` at the beginning is [documented](https://spotbugs.readthedocs.io/en/stable/filter.html#java-element-name-matching). Although, it took me some time to find that. Maybe all parts which...