sigutils icon indicating copy to clipboard operation
sigutils copied to clipboard

Add Cmake module as part of the installation/packaging

Open studiofuga opened this issue 1 year ago • 3 comments

This PR packages the library with cmake files, allowing CMake projects to automatically find it and configure the compilation and linking. It also adds a test project in a subdirectory of the test directory. Once installed, the installation can be tested by building the test project with cmake.

studiofuga avatar Jun 20 '23 12:06 studiofuga

Documentation coverage report

Element Value
Defines 0.0% (0/351)
Enum Values 0.0% (0/38)
Enums 0.0% (0/12)
Files 0.0% (0/86)
Functions 0.0% (0/706)
Structs 0.0% (0/46)
Typedefs 0.0% (0/39)
Variables 0.0% (0/446)
Total 0.0% (0/1724)

github-actions[bot] avatar Jun 20 '23 12:06 github-actions[bot]

Hi @studiofuga! Thanks for the contribution! :)

While having a look at it it seems that you have added a testfile wich has a main function to the existing test harness wich already has a make function. This seems to break the unit testing infraestructure. I am not sure why that seems to be working in MacOS and Windows 🤔

antoniovazquezblanco avatar Jun 23 '23 17:06 antoniovazquezblanco

Hi Antonio, indeed that's definitely puzzling. The testfile was meant to test the installation of the cmake project files, including the modules I just realized. The subproject isn't related in the cmake files, because it is completely unrelated. So it's a bit strange that it is taken into account by the CI system. Anyway, we have two options, 1. fix the ci and 2. remove it entirely. I haven't experience with CI so if it was for me, I'd opt for 2, though it might be interesting to have it for future tests. What do you think?

studiofuga avatar Jun 24 '23 08:06 studiofuga