Lector icon indicating copy to clipboard operation
Lector copied to clipboard

Flexible line spacing?

Open nickcorona opened this issue 6 years ago • 9 comments

Currently, if you set line padding to a certain value, it maintains that same value when you make the window full-screen or not. So, line spacing changes depending on the size of the window. This isn't ideal; line spacing should remain constant, and line padding should change depending on the size of the window.

nickcorona avatar Jun 03 '18 13:06 nickcorona

You're correct. I'll fix this in the next commit.

BasioMeusPuga avatar Jun 04 '18 18:06 BasioMeusPuga

Was this resolved? I found this while testing:

lector-line-spacing-test

elisamalzoni avatar Oct 24 '19 12:10 elisamalzoni

Ok, I'll be working on this.

elisamalzoni avatar Oct 31 '19 12:10 elisamalzoni

Hello. I'm afraid I've been on a break from development due to unavoidable IRL circumstances. That said, please help me understand this better. In that gif both padding and line spacing seems fixed to me - which is intended behavior. Am I correct in assuming you'd like the padding to change so that the text occupies the same area regardless of window size?

BasioMeusPuga avatar Oct 31 '19 15:10 BasioMeusPuga

Hello. I'm afraid I've been on a break from development due to unavoidable IRL circumstances. That said, please help me understand this better. In that gif both padding and line spacing seems fixed to me - which is intended behavior. Am I correct in assuming you'd like the padding to change so that the text occupies the same area regardless of window size?

That's correct. If the goal is to set line spacing to a constant value it should be maintained when you expand the window.

nickcorona avatar Nov 02 '19 18:11 nickcorona

I am trying to implement the padding relative to the window size, I'll make a PR when I am done.

elisamalzoni avatar Nov 07 '19 11:11 elisamalzoni

I think i got it! You wanted something like this?

padding_ot

Now the padding is relative to the window width.

elisamalzoni avatar Nov 07 '19 13:11 elisamalzoni

I've done the PR. Was that it? @nickcorona @BasioMeusPuga

elisamalzoni avatar Nov 14 '19 14:11 elisamalzoni