bash-it icon indicating copy to clipboard operation
bash-it copied to clipboard

Published 20 hours ago • verified publisher icon Bash-it

Add new theme - Inretio

Open gytisrepecka opened this issue 11 months ago • 2 comments

Add new theme called Inretio, along with documentation describing it.

Description

Inretio theme uses inspiration from existing themes: metal and bobby, but adds more details about virtual environment - when Python is available in it, prompt will display that particular Python binary version.

Motivation and Context

Displaying specific Python version is very useful for developers who keep multiple venvs for running their Python code on different runner versions, e.g.: 3.12.x and 3.9.x on the same machine.

How Has This Been Tested?

Tested on usual filesystem folder, Git-tracked folder, in venv without Python and in venv with Python.

Screenshots (if appropriate):

Added in documentation as required: https://github.com/Bash-it/bash-it/pull/2246

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] If my change requires a change to the documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • [ ] I have added tests to cover my changes, and all the new and existing tests pass.

gytisrepecka avatar Mar 20 '24 10:03 gytisrepecka

~~It looks like there is an error in linter:~~

Bash include file themes/inretio/inretio.theme.bash has bad/missing shellcheck header

Because following is indeed the recommended shebang to properly find BASH location:

#!/usr/bin/env bash

Edit: not related to shebang - actually theme file needed following on top of it:

# shellcheck shell=bash
# shellcheck disable=SC2034 # Expected behavior for themes.

gytisrepecka avatar Mar 20 '24 10:03 gytisrepecka

Currently have no idea what Linter wants me to fix. Is there a usable documentation to understand and troubleshoot Linter issues?

Current documentation hardly helps 🧐

gytisrepecka avatar Mar 28 '24 10:03 gytisrepecka